Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/pmdPublic

Comments

[java] ImmutableField - remove @Getter#4490

Merged
jsotuyod merged 1 commit intopmd:masterfrom
adangel:java-immutable-field-getter
Apr 20, 2023
Merged

[java] ImmutableField - remove @Getter#4490
jsotuyod merged 1 commit intopmd:masterfrom
adangel:java-immutable-field-getter

Conversation

@adangel
Copy link
Member

Describe the PR

This fixes a potential false negative when@Getter is used. See discussion on#4474:

I think that a field (or class) being annotated with the@Getter annotation should not be a > reason to exempt from the ImmutableField rule. After all, it only generates a getter, meaning > the field can still be marked final.

Originally posted by@PimvanderLoos in#4474 (comment)

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

This fixes a potential false negative when@Getter is used.See discussion onpmd#4474
@adangeladangel added the a:false-negativePMD doesn't flag a problematic piece of code labelApr 20, 2023
@adangeladangel added this to the7.0.0 milestoneApr 20, 2023
@ghost
Copy link

1 Message
📖Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫Danger

@jsotuyodjsotuyod merged commit1cdd09b intopmd:masterApr 20, 2023
@adangeladangel deleted the java-immutable-field-getter branchApril 20, 2023 15:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a:false-negativePMD doesn't flag a problematic piece of code

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adangel@jsotuyod

[8]ページ先頭

©2009-2026 Movatter.jp