This allows to derive serialize/deserialize for the color structs which are very simple using the default implementation, allowing to pass colors along via serialization channels and formats.

10ne1 force-pushed thedev/aratiu/allow-serializing-colors branch from3df125c to030a21aCompare

November 1, 2024 15:40

AaronErhardt requested changes

Nov 12, 2024

View reviewed changes

Copy link

Member

AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I totally understand the intend of the PR and I agree that this is useful. However, some might want to use plotters without pulling in serde as dependency. Therefore, this feature should be added behind a feature flag IMO.

10ne1 force-pushed thedev/aratiu/allow-serializing-colors branch from030a21a to5eb2238Compare

December 4, 2024 08:21

style/color: derive serialize & deserialize

7f96558

Using serde is useful in production, not just during development,so move it to optional dependencies instead of dev-dependencies.This allows to derive serialize/deserialize for the color structswhich are very simple using the default implementation, allowingto pass colors along via serialization channels and formats.

10ne1 force-pushed thedev/aratiu/allow-serializing-colors branch from5eb2238 to7f96558Compare

December 4, 2024 08:51

Copy link

ContributorAuthor

10ne1 commentedDec 4, 2024

Hello@AaronErhardt and thank you for your patience!

I've updated the PR to make serde an optional dependency while still keeping it enabled in dev-dependencies and added a small documentation blurb for the newserialization feature.

AaronErhardt approved these changes

Dec 6, 2024

View reviewed changes

Copy link

Member