NotificationsYou must be signed in to change notification settings
Fork301
Star4.2k

Support for bar graphs. Helps with issue #98#111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

matiu2 wants to merge4 commits intoplotters-rs:master

base:master

Choose a base branch

frommatiu2:master

Open

Support for bar graphs. Helps with issue #98#111

matiu2 wants to merge4 commits intoplotters-rs:masterfrommatiu2:master

Conversation

Copy link

codecovbot commentedFeb 12, 2020•
edited
Loading

Codecov Report

Merging#111 (a06f868) intomaster (dee7727) willdecrease coverage by1.37%.
The diff coverage is13.63%.

@@            Coverage Diff             @@##           master     #111      +/-   ##==========================================- Coverage   67.48%   66.11%   -1.38%==========================================  Files          53       53                Lines        5160     5152       -8     ==========================================- Hits         3482     3406      -76- Misses       1678     1746      +68

Impacted Files	Coverage Δ
src/coord/category.rs	`62.06% <13.63%> (-16.72%)`	⬇️
src/coord/logarithmic.rs	`0.00% <0.00%> (-60.00%)`	⬇️
src/style/font/ttf.rs	`72.52% <0.00%> (-7.91%)`	⬇️
src/series/line_series.rs	`71.87% <0.00%> (-4.60%)`	⬇️
src/drawing/rasterizer/line.rs	`67.34% <0.00%> (-3.63%)`	⬇️
src/element/boxplot.rs	`77.77% <0.00%> (-2.51%)`	⬇️
src/drawing/backend.rs	`58.82% <0.00%> (-2.36%)`	⬇️
src/style/font/font_desc.rs	`47.67% <0.00%> (-2.33%)`	⬇️
src/drawing/backend_impl/bitmap.rs	`83.21% <0.00%> (-2.32%)`	⬇️
src/drawing/backend_impl/svg.rs	`73.47% <0.00%> (-2.07%)`	⬇️
... and21 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatedee7727...12f8430. Read thecomment docs.

matiu2 force-pushed themaster branch 2 times, most recently from8d20955 toa06f868Compare

February 12, 2020 13:54

Copy link

Member

I think the PR looks good to me. I am currently working on a new major release shipping with discrete coordinate trait refactor#89 and slice coordinate support#104 . With those changes,Category will be removed and slice will be able to use as coordinate spec directly. (Actually the discrete coordinate trait has been messed up for a long time)

One of the related example on this change would behttps://github.com/38/plotters/blob/v0.3-pre/examples/nested_coord.rs Though it's not really the bar chart but roughly shows how things work.

And here's a quick example use v0.3:

use plotters_bitmap::BitMapBackend;use plotters::prelude::*;fnmain(){letmut root =BitMapBackend::new("out.png",(800,600)).into_drawing_area();    root.fill(&WHITE);let data =["a","b","c","d","e"];letmut chart =ChartBuilder::on(&root).set_all_label_area_size(30).build_ranged((&data[..]).into_centric(),0..10).unwrap();    chart.configure_mesh().disable_mesh().draw();let hist =Histogram::vertical(&chart).data(vec![(&"a",5),(&"b",2),(&"c",8),(&"d",7),(&"e",4)]).margin(15);    chart.draw_series(hist);}