- Notifications
You must be signed in to change notification settings - Fork301
Commitdd806bd
committed
coord: ranged1d: fix irrefutable if let warning
I keep getting this annoying warning with rust 1.83:warning: irrefutable `if let` pattern --> plotters/src/coord/ranged1d/types/numeric.rs:29:20 |29 | if let Ok(index) = Self::ValueType::try_from(index) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...365 | impl_discrete_trait!(RangedCoordusize); | -------------------------------------- in this macro invocation | = note: this pattern will always match, so the `if let` is useless = help: consider replacing the `if let` with a `let` = note: `#[warn(irrefutable_let_patterns)]` on by default = note: this warning originates in the macro `impl_discrete_trait` (in Nightly builds, run with -Z macro-backtrace for more info)This is because the conversion of usize to ValueType alwayspasses, so we don't need the try_from() in all cases.An additional problem are potential overflows so we usechecked_add() which returns None if the addition fails,thus also avoiding the irrefutable let pattern while alsoprotecting against overflows.Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>1 parent3ad52da commitdd806bd
1 file changed
+3
-4
lines changedLines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
| |||
0 commit comments
Comments
(0)