Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Hook-based API#275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JamesRamm wants to merge5 commits intoplotly:master
base:master
Choose a base branch
Loading
fromJamesRamm:patch-1
Open

Hook-based API#275

JamesRamm wants to merge5 commits intoplotly:masterfromJamesRamm:patch-1

Conversation

JamesRamm
Copy link

@JamesRammJamesRamm commentedFeb 9, 2022
edited
Loading

As discussed in#242 here is a simple hook-based API for react-plotly.

Usage

The hook gives you aref and two streams:updates andappendData.

Here is an example:

functionMyChart(props){const{ ref, updates, appendData}=usePlotly();// Here is a function that will change the data. You must pass a partial Figure object (plotly DSL object) which will be// merged with all previous calls to `updates`constchangeData=()=>updates({data:[{y:[Math.random()*10],type:'scatter'}]})// Here we start extending traces using the `appendData` streamconstextendData=setInterval(()=>{appendData({data:{y:[[Math.random()*10]]},tracePos:[0]});},500);return(<div><divref={ref}style={{width:'500px',height:'300px'}}/><buttononClick={changeData}>React!</button><buttononClick={extendData}>Extend!</button></div>);}

updates can be treated as a function that you can give partialFigure definitions to and it will update the graph usingPlotly.react
appendData can also be used as a function which is directly mapped on toPlotly.extendTraces every time it is called.

Advantages

neka-nat, govind-ootb, timsntech, rburchDev, chris-lear, Yohannfra, govindthakur25, vinhtru, zzztop, renegoretzka, and 8 more reacted with thumbs up emojialxpez reacted with hooray emoji
Copy link

@himbeleshimbeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

minor fix regarding requirement versions

@govindthakur25
Copy link

Suggestion: It would be good to have a section in the README for this hook, with a few working codepen examples.

Adds example of `usePlotly`
@JamesRamm
Copy link
Author

@govindthakur25
I have added a README section.

@himbeles
What is needed to get this merged? Can we go ahead?

govindthakur25, Dyocius, vinhtru, and peop81 reacted with thumbs up emoji

@JamesRamm
Copy link
Author

Bump
Not sure what is needed to get this merged...

peop81 reacted with thumbs up emoji

@himbeles
Copy link

@govindthakur25

I have added a README section.

@himbeles

What is needed to get this merged? Can we go ahead?

Just to clarify, I'm not a maintainer of this project.

@Dyocius
Copy link

@nicolaskruchten Do you know who the maintainer of this repo is?

@JamesRamm
Copy link
Author

I am just going to put some names of previous committers here in the hope of getting some movement:

@alexcjohnson
@nicolaskruchten
@bpostlethwaite

Sorry for the spam but it seems there is no-one actively looking at this repo?

@alexcjohnson
Copy link
Collaborator

@JamesRamm apologies for the silence from us maintainers. This looks great! I'll make a few comments on the code itself, but the one extra thing I'll ask is some basic tests - either add tohttps://github.com/plotly/react-plotly.js/blob/master/src/__tests__/react-plotly.test.js or put a new file next to it for this purpose. We do have this repo connected to CircleCIhttps://app.circleci.com/pipelines/github/plotly/react-plotly.js - hopefully the config changes I just made there will enable it to (a) run on this and other forked PRs and (b) show up in the status of this PR 🤞

"react": ">0.13.0"
"react": ">0.13.0",
"flyd": ">=0.2.8",
"ramda": ">=0.28.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

flyd andramda seem like they'd be better asdependencies rather thanpeerDependencies - and then let's change from>= to^

Copy link

@floriancargoetfloriancargoetOct 13, 2022
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are 2 news deps really required?
ramda seems to be used just to write this code in the functional style.
The author himself said in the related issue that it could be replaced with:

function getSizeForLayout(entries) {    const { width, height } = entries[0].contentRect;    return { layout: { width, height } };}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good question@floriancargoet -ramda has a couple of other uses in this PR (and we do use it a good deal elsewhere at Plotly), but to my mind yourgetSizeForLayout rewrite is more readable than the full functional version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While yesgetSizeForLayout can be written easily withoutramda (happy to do this), the main reason it was included was formergeDeepRight which is a relatively complex function to implement.
We could go for an independent implementation but my argument would be thatramda is relatively small and compatible with tree shaking

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Right, deep merge is annoying to reimplement. I have no problem adding this (andflyd) but I do think they belong independencies.

Plotly.react(internalRef, state);
});

const endAppend = appendData.map(({ data, tracePos }) => Plotly.extendTraces(internalRef, data, tracePos));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since you've implementedextendTraces here, let's finish it by includingmaxPoints (the optional 4th argument toextendTraces)

JamesRamm reacted with thumbs up emoji
const appendData = useMemo(stream, []);
const plotlyState = useMemo(
() => scan(mergeDeepRight, { data: [], config: {}, layout: {} }, updates),
[]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn'tupdates be added to the dependencies list here since it's used inside the hook?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sinceupdates is memoized with an empty array, it will only be computed once on mount, so adding it to the dependencies array or not forplotlyState will have no effect....

endS.end(true);
};
}
}, [internalRef, plotlyState, updates, appendData]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn'tobserver be added as a dependency here since it's used inside the hook?

nlappas reacted with thumbs up emoji
@Michael-fore
Copy link

Michael-fore commentedMay 19, 2023
edited
Loading

Y'all... uhhh... gonna merge this?

@alexcjohnson

@alexcjohnson
Copy link
Collaborator

There are a number of unresolved review comments before we can merge

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@floriancargoetfloriancargoetfloriancargoet left review comments

@terebentinaterebentinaterebentina left review comments

@alexcjohnsonalexcjohnsonalexcjohnson left review comments

@himbeleshimbeleshimbeles requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@JamesRamm@govindthakur25@himbeles@Dyocius@alexcjohnson@Michael-fore@floriancargoet@terebentina

[8]ページ先頭

©2009-2025 Movatter.jp