Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork137
import plotly.js-dist v2 instead of v1 plotly.js/dist#260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5222ccd
to40dfac1
Comparedmbarry86 commentedSep 7, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have tested this with our own components and can confirm that this now allows the use of plotly.js-dist alongside this library.plotly/plotly.js#5925 (comment) If this was to be merged then I think the installation section of the readme would also need updating. This would also be considered a breaking change for anybody currently using this library with plotly.js. |
It should already be possible to use a |
dmbarry86 commentedSep 7, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicolaskruchten I think there's a broken link there. When clicking on "assemble you own customized bundle" it just takes to main plotly.js readme. I think the point here is that this library is now no longer aligned with the recommendations from plotly.js which itself now promotes the use of plotly.js-dist rather than plotly.js. Sure, we could all go ahead and write some custom code to use a different bundle but then how many different people need to do that? Makes sense to me to align the default setup of this library with the default (as of v2) recommendations from plotly.js. |
Yes, we should, I agree, but given that we're feeling pretty short-handed at the moment, I'm providing you with options that you can use today :) |
Here's where that link should point:https://github.com/plotly/plotly.js/blob/master/CUSTOM_BUNDLE.md |
jacksongoode commentedMay 8, 2023
This would reduce the bundle size no?@archmoj |
saimidu commentedJul 1, 2024
Hi@nicolaskruchten@dmbarry86, were there any further steps to resolve this dependency issue? I see that this PR has been open for a number of years without any resolution. |
jacksongoode commentedJul 1, 2024
@saimidu I don't think either of them still work at Plotly. |
Supersedes#205.
Closes#248 andfixes#258.
Addressesplotly/plotly.js#5925 (comment).
Please note that this appears to be a breaking change for this repository.
@plotly/plotly_js