Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

import plotly.js-dist v2 instead of v1 plotly.js/dist#260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
archmoj wants to merge8 commits intomaster
base:master
Choose a base branch
Loading
fromswitch-to-plotly.js-dist

Conversation

archmoj
Copy link

Supersedes#205.
Closes#248 andfixes#258.
Addressesplotly/plotly.js#5925 (comment).

Please note that this appears to be a breaking change for this repository.

@plotly/plotly_js

@dmbarry86
Copy link

dmbarry86 commentedSep 7, 2021
edited
Loading

I have tested this with our own components and can confirm that this now allows the use of plotly.js-dist alongside this library.plotly/plotly.js#5925 (comment)

If this was to be merged then I think the installation section of the readme would also need updating.

This would also be considered a breaking change for anybody currently using this library with plotly.js.

archmoj reacted with thumbs up emoji

@nicolaskruchten
Copy link
Contributor

It should already be possible to use adist bundle with this library without changingpackage.json ... Check out this section of the readme:https://github.com/plotly/react-plotly.js#customizing-the-plotlyjs-bundle

@dmbarry86
Copy link

dmbarry86 commentedSep 7, 2021
edited
Loading

@nicolaskruchten I think there's a broken link there. When clicking on "assemble you own customized bundle" it just takes to main plotly.js readme.

I think the point here is that this library is now no longer aligned with the recommendations from plotly.js which itself now promotes the use of plotly.js-dist rather than plotly.js. Sure, we could all go ahead and write some custom code to use a different bundle but then how many different people need to do that? Makes sense to me to align the default setup of this library with the default (as of v2) recommendations from plotly.js.

@nicolaskruchten
Copy link
Contributor

Yes, we should, I agree, but given that we're feeling pretty short-handed at the moment, I'm providing you with options that you can use today :)

@nicolaskruchten
Copy link
Contributor

Here's where that link should point:https://github.com/plotly/plotly.js/blob/master/CUSTOM_BUNDLE.md

archmoj and bykof reacted with thumbs up emoji

@jacksongoode
Copy link

This would reduce the bundle size no?@archmoj

archmoj reacted with thumbs up emoji

@saimidu
Copy link

Hi@nicolaskruchten@dmbarry86, were there any further steps to resolve this dependency issue? I see that this PR has been open for a number of years without any resolution.

jacksongoode reacted with thumbs up emoji

@jacksongoode
Copy link

@saimidu I don't think either of them still work at Plotly.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use plotly.js-dist with react-plotly.js? Support for Plotly 2.x
5 participants
@archmoj@dmbarry86@nicolaskruchten@jacksongoode@saimidu

[8]ページ先頭

©2009-2025 Movatter.jp