Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MRG] histogram nb#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
emmanuelle merged 6 commits intomasterfromhistogram
Jun 21, 2019
Merged

[MRG] histogram nb#2

emmanuelle merged 6 commits intomasterfromhistogram
Jun 21, 2019

Conversation

emmanuelle
Copy link
Contributor

No description provided.

@emmanuelle
Copy link
ContributorAuthor

Is it ok to do one PR per notebook? Or for the review is it better to group them? I don't mind.

@emmanuelleemmanuelle changed the titlefirst pass at histogram nb[MRG] histogram nbJun 16, 2019
py.iplot(fig, filename='styled histogram')
fig.update(layout=go.Layout(
title='Sampled Results', # title of plot
xaxis_title='Value', # xaxis label
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

reading this reminds me that we should use the new-styletitle object instead of string:https://github.com/plotly/plotly.py-docs/issues/17

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, I will change this. However inpx the argument is calledtitle and nottitle_text should this be changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm comfortable withpx keepingtitle as it's designed to be a lighter-weight API :)

@emmanuelle
Copy link
ContributorAuthor

Comments addressed!

@nicolaskruchten
Copy link
Contributor

💃

@emmanuelleemmanuelle merged commita6d5252 intomasterJun 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolaskruchtennicolaskruchtennicolaskruchten left review comments

@chriddypchriddypchriddyp left review comments

@michaelbabynmichaelbabynmichaelbabyn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@emmanuelle@nicolaskruchten@chriddyp@michaelbabyn
[8]ページ先頭
©2009-2025 Movatter.jp