Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
update plotly.js to v3.3.0#5421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
41ba335 to83ab425CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@camdecoster fyi: Turns outpackage-lock.json inherits its indentation frompackage.json by default, so if we keeppackage.json at 2 spaces,package-lock.json needs to be two spaces as well.
a3480f0 changes the indentation,83ab425 updates the actual contents of the lockfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What a fun world we live in. For future reference,here's the doc page describing this:
When
npmcreates or updatespackage-lock.json, it will infer line endings and indentation frompackage.jsonso that the formatting of both files matches.
56873c3 tof687526CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What a fun world we live in. For future reference,here's the doc page describing this:
When
npmcreates or updatespackage-lock.json, it will infer line endings and indentation frompackage.jsonso that the formatting of both files matches.
a49f495 intomainUh oh!
There was an error while loading.Please reload this page.
plotly.js v3.3.0 release notes:https://github.com/plotly/plotly.js/releases/tag/v3.3.0