Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.7k
create_hexbin_mapbox uses *_map chart types instead of *_mapbox#5358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ajlien wants to merge3 commits intoplotly:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Looks like they failed on the same Python code block(1),(2): with Did upload.wikimedia.org block the resource request? |
Hi@ajlien , thanks for catching this, we should definitely migrate this function to use The doc build failure has been fixed on We should also deprecate
defcreate_hexbin_mapbox(*args,**kwargs):warnings.warn("create_hexbin_mapbox() is deprecated and will be removed in the next major version. "+"Please use create_hexbin_map() instead. "+"Learn more at: https://plotly.com/python/mapbox-to-maplibre/",stacklevel=2,category=DeprecationWarning, )if"mapbox_style"inkwargs:kwargs["map_style"]=kwargs.pop("mapbox_style")returncreate_hexbin_map(*args,**kwargs)
I'm happy to take over this branch if you don't have the bandwidth, but if you get around to it first, go for it! Thanks again. |
Thanks Emily! Can do today. …On Wed, Oct 1, 2025, 4:48 PM Emily KL ***@***.***> wrote: *emilykl* left a comment (plotly/plotly.py#5358) <#5358 (comment)> Hi@ajlien <https://github.com/ajlien> , thanks for catching this, we should definitely migrate this function to use _map traces. The doc build failure has been fixed on main, if you merge main into your branch the issue should be resolved. We should also deprecate create_hexbin_mapbox() and rename it to create_hexbin_map(). Could you add the following changes to this branch? - Rename the function from create_hexbin_mapbox() to create_hexbin_map() - Rename the mapbox_style arg to map_style - Add a new create_hexbin_mapbox() function which shows a DeprecationWarning and then calls create_hexbin_map(), i.e. something like this: def create_hexbin_mapbox(*args, **kwargs): warnings.warn( "create_hexbin_mapbox() is deprecated and will be removed in the next major version. " + "Please use create_hexbin_map() instead. " + "Learn more at:https://plotly.com/python/mapbox-to-maplibre/", stacklevel=2, category=DeprecationWarning, ) if "mapbox_style" in kwargs: kwargs["map_style"] = kwargs.pop("mapbox_style") return create_hexbin_map(*args, **kwargs) - Update plotly/figure_factory/__init__.py accordingly I'm happy to take over this branch if you don't have the bandwidth, but if you get around to it first, go for it! Thanks again. — Reply to this email directly, view it on GitHub <#5358 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFOQA5YR7KS3USQPF6KHDAL3VQ4YHAVCNFSM6AAAAACIAXVOCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJYGA4DANBTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***> |
gvwilson approved these changesOct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
plotly.graph_objects, my modifications concern the code generator andnot the generated files.Small change to remove mapbox references from figure factory's hexbin map. See#5081 in particular@danielsaaf'scomment.
No
docstrings orkwarg names needed to be changed, this is just a substitution.As a side effect (and the reason I originally came across this issue), currrently if you construct a figure with
create_hexbin_mapboxthen add anothergo.Scattermaptrace to it, any maki symbols in the scattermap will not render. This PR also fixes that.