NotificationsYou must be signed in to change notification settings
Fork2.8k
Star18.1k

Small fix to Histogram2dContour setup in plotly express#5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

gmjw wants to merge2 commits intoplotly:main

base:main

Choose a base branch

fromgmjw:fix-histogram-contour-construction

Open

Small fix to Histogram2dContour setup in plotly express#5342

gmjw wants to merge2 commits intoplotly:mainfromgmjw:fix-histogram-contour-construction

+1 −1

Conversation

Copy link

Contributor

gmjw commentedSep 5, 2025•
edited
Loading

As per the docs, ifz is passed in with no histfunc, it should be set to'sum':

I think this corrects the intended behaviour and puts Histogram2dContour more in line with Histogram2d.

I have read through thecontributing notes and understand the structure of the package. In particular, if my PR modifies code ofplotly.graph_objects, my modifications concern the code generator andnot the generated files.
I have added tests or modified existing tests.
For a new feature, I have added documentation examples (please see the doc checklist as well).
I have added a CHANGELOG entry if changing anything substantial.
For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

fix

e37fa2b

gmjw changed the title~~fix~~Small fix to Histogram2dContour setup in plotly express

Sep 5, 2025

Copy link

ContributorAuthor

gmjw commentedSep 5, 2025

If a more experienced contributor takes a look at this - I can't understand why the Circle CI build has failed, the error message doesn't indicate anything clearly - any advice appreciated.