Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Copy width/height calculating logic from kaleido#5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
emilykl merged 10 commits intoplotly:mainfromgeopozo:andrew/better-kaleido-defaults
Aug 19, 2025

Conversation

@ayjayt
Copy link
Contributor

@ayjaytayjayt commentedAug 13, 2025•
edited
Loading

Code PR

  • I have read through thecontributing notes and understand the structure of the package. In particular, if my PR modifies code ofplotly.graph_objects, my modifications concern the code generator andnot the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

plotly/Kaleido#378

janosh reacted with thumbs up emoji
@ayjayt
Copy link
ContributorAuthor

ayjayt commentedAug 13, 2025•
edited by emilykl
Loading

closesplotly/Kaleido#378

@emilykl
Copy link
Contributor

Looks good@ayjayt ! Just runruff format onplotly/io/_kaleido.py so the CI will pass.

Let's add a test for this one. I'm happy to do that if you don't have the bandwidth, just let me know.

ayjaytand others added6 commitsAugust 14, 2025 15:00
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ayjaytayjayt marked this pull request as ready for reviewAugust 14, 2025 21:04
@ayjaytayjayt requested a review fromemilyklAugust 14, 2025 21:04
mock_get_chrome.assert_called_once()


defcreate_figure(width=None,height=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: could you move these two utility functions to the top of the file so they're not mixed in with the test functions?

ayjayt reacted with thumbs up emoji
fig=create_figure()
svg_bytes=pio.to_image(fig,format="svg")
width,height=parse_svg_dimensions(svg_bytes)
assertwidthisnotNoneandheightisnotNone, (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should be able to importpio.defaults here and check that the dimensions equal the defaults

ayjayt reacted with thumbs up emoji
Copy link
Contributor

@emilyklemilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@ayjayt ! 🚀

@ayjaytayjayt requested a review fromemilyklAugust 18, 2025 20:28
@emilykl
Copy link
Contributor

@ayjayt Looks good to me -- may I merge?

@emilyklemilykl merged commit7639653 intoplotly:mainAug 19, 2025
8 checks passed
@ayjaytayjayt deleted the andrew/better-kaleido-defaults branchAugust 19, 2025 18:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@emilyklemilyklAwaiting requested review from emilykl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ayjayt@emilykl
[8]ページ先頭
©2009-2025 Movatter.jp