Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix tick marker mirroring (matplotlib conversion)#5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
robertoffmoura wants to merge2 commits intoplotly:main
base:main
Choose a base branch
Loading
fromrobertoffmoura:rm/fix-tick-marker-mirroring

Conversation

robertoffmoura
Copy link
Contributor

Hi,

This fixes the issue where a matplotlib figure with only bottom and left tick markers would be converted to a plotly figure with markers on all sides.

Code PR

  • I have read through thecontributing notes and understand the structure of the package. In particular, if my PR modifies code ofplotly.graph_objects, my modifications concern the code generator andnot the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@robertoffmourarobertoffmouraforce-pushed therm/fix-tick-marker-mirroring branch 2 times, most recently from3fafa67 todaf0327CompareAugust 8, 2025 11:06
@gvwilsongvwilson requested a review fromemilyklAugust 11, 2025 17:07
@gvwilsongvwilson added P1needed for current cycle communitycommunity contribution fixfixes something broken labelsAug 11, 2025
@robertoffmourarobertoffmouraforce-pushed therm/fix-tick-marker-mirroring branch from860b8b0 to001ff53CompareAugust 12, 2025 09:31
@emilykl
Copy link
Contributor

Hi@robertoffmoura, thank you for the fix! Same question here, could you provide some side-by-side comparisons to show the difference this PR introduces and why this is the correct behavior? I'm not very familiar with axis mirroring in matplotlib (or Plotly for that matter) so just trying to sanity check that these changes make sense.

I took a quick look at the images of the plots in the tests you added, and the only one where I see a difference between your branch andmain is in theaxis_mirror_false_with_one_sided_ticks function, is that expected?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@emilyklemilyklAwaiting requested review from emilykl

At least 1 approving review is required to merge this pull request.

Assignees

@emilyklemilykl

Labels
communitycommunity contributionfixfixes something brokenP1needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@robertoffmoura@emilykl@gvwilson

[8]ページ先頭

©2009-2025 Movatter.jp