Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Resolve issue causing extraneousengine deprecation warnings#5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jdbeel
Copy link
Contributor

Code PR

  • I have read through thecontributing notes and understand the structure of the package. In particular, if my PR modifies code ofplotly.graph_objects, my modifications concern the code generator andnot the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@jdbeel
Copy link
ContributorAuthor

jdbeel commentedJul 21, 2025•
edited
Loading

Fixes the issue in#5286

I don't believe any docstrings need updating as the ones for the classes/methods I changed do not reference the default for the engine argument. The default was also changed toNone further up the API. I believe this should basically be a NOP for most users/flows. If this warrants a change in the CHANGELOG, please let me know. I figured for the above reasons it did not.

@gvwilsongvwilson requested a review fromemilyklAugust 1, 2025 12:18
@gvwilsongvwilson added P1needed for current cycle communitycommunity contribution fixfixes something broken labelsAug 1, 2025
@emilyklemilykl changed the titleUpdate external image renderer engine defaultsfix: Resolve issue causing extraneousengine deprecation warningsAug 1, 2025
Copy link
Contributor

@emilyklemilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for running this down@jdbeel, this is great.

I agree, this should be a noop since inside theto_image function,engine is set to"auto" ifNone is passed.

Once theengine argument is removed from theto_image andwrite_image functions, we should remove it from these functions as well. Until then this is a good solution.

🚀

@emilyklemilykl merged commit480a1af intoplotly:mainAug 1, 2025
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@emilyklemilyklemilykl approved these changes

Assignees

@emilyklemilykl

Labels

communitycommunity contributionfixfixes something brokenP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdbeel@emilykl@gvwilson
[8]ページ先頭
©2009-2025 Movatter.jp