Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Exposeplotly.io.get_chrome()#5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
emilykl merged 3 commits intomainfrom5272-add-plotly-io-get-chrome
Jul 16, 2025
Merged

Conversation

@emilykl
Copy link
Contributor

@emilyklemilykl commentedJul 16, 2025
edited
Loading

Closes#5272

Exposeplotly.io.get_chrome() as a function which can be called from within a Python script.

get_chrome() accepts one optional argument,path, which is the location to download Chrome to; if not supplied, the default location defined bychoreographer will be used.

This PR also slightly refactorsget_chrome() into two functions:

  • get_chrome(), which is intended to be called directly in code, and
  • plotly_get_chrome(), which is a CLI wrapper forget_chrome() and intended to be called via theplotly_get_chrome command from the command line.

On this branch, running the following code should work:

importplotly.ioaspiopio.get_chrome()

The path to the directory where Chrome should be installed.
If None, the default download path will be used.
"""
ifnotkaleido_available()orkaleido_major()<1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why a confirmation? (not arguing, just think it's very unlikely someone would call the function by accident)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you mean the one on line 837? I agree it's unlikely to be called by accident, but I mainly put it there so users could confirm that the install path makes sense.

In any case, the confirmation only appears when using the command-lineplotly_get_chrome command, not when calling theplotly.io.get_chrome() function within a script.

@emilyklemilykl merged commit4cd70ad intomainJul 16, 2025
10 checks passed
@emilyklemilykl deleted the 5272-add-plotly-io-get-chrome branchNovember 6, 2025 18:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@LiamConnorsLiamConnorsLiamConnors approved these changes

+1 more reviewer

@gvwilsongvwilsongvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report:plotly.io.install_chrome() documented but doesn't exist

4 participants

@emilykl@gvwilson@LiamConnors

[8]ページ先頭

©2009-2025 Movatter.jp