Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.7k
Fix add hline not working for make_subplot if not populated#5254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Erikp15 wants to merge7 commits intoplotly:mainChoose a base branch fromErikp15:fix-add_hline-not-working
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…5/plotly.py into fix-add_hline-not-working
…rorsThis reverts commitb92a744.
Hi@gvwilson , just checking in to see if there's anything else needed from my end on this PR. Happy to make any changes if needed. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is a proposal fix for issue#5136
I first reproduced the issue and created two unit tests,
test_add_hline_empty_subplots.py
andtest_hline_subplots_bug.py
, that check if the bug is resolved. Then I implemented the fix (outlined below), which passed both of the new unit tests, and in the process, no old tests were broken.Root cause
add_shape()
is called withexclude_empty_subplots=True
. For a freshmake_subplots
figure, every subplot is flagged empty, so the h/v line shape is filtered out and never appears, even after traces are later added.Fix overview
When
add_hline
/add_vline
are invoked and the figure contains no traces (len(self.data)==0
), the code now disables the exclude empty subplots logic before delegating toadd_shape
, allowing the shape to be created and later displayed once data is added.Code PR
plotly.graph_objects
, my modifications concern the code generator andnot the generated files.