Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix 5186 type checking renegerate code#5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvwilson merged 3 commits intomainfromfix-5186-type-checking-renegerate-code
May 27, 2025

Conversation

@gvwilson
Copy link
Contributor

@gvwilsongvwilson requested a review fromemilyklMay 22, 2025 18:59
@gvwilsongvwilson self-assigned thisMay 22, 2025
@gvwilsongvwilson added P1needed for current cycle fixfixes something broken regressionthis used to work labelsMay 22, 2025
Copy link
Contributor

@emilyklemilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Confirming that this seems to fix syntax highlighting in VSCode on my machine.

-   Restore code removed in#4978.-   (Partially)closes#5186.-   Remove unneeded imports of `sys`.
-   Restore code removed in#4978.-   Add `test_path.png` to `.gitignore`.-Closes#5186.
@gvwilsongvwilsonforce-pushed thefix-5186-type-checking-renegerate-code branch from848f68e to44907a3CompareMay 25, 2025 12:48
@gvwilson
Copy link
ContributorAuthor

updated to removesys imports and check again version 3.7

@kszlim
Copy link

I'm curious if there will be a (relatively quick) patch version released once this makes it in?

@gvwilson
Copy link
ContributorAuthor

@kszlim coming soon

kszlim reacted with hooray emoji

@gvwilsongvwilson merged commit7bc7ce5 intomainMay 27, 2025
10 checks passed
@gvwilsongvwilson deleted the fix-5186-type-checking-renegerate-code branchJune 4, 2025 12:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@emilyklemilyklemilykl approved these changes

Assignees

@gvwilsongvwilson

Labels

fixfixes something brokenP1needed for current cycleregressionthis used to work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gvwilson@kszlim@emilykl
[8]ページ先頭
©2009-2025 Movatter.jp