Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: restore type checking portion of code generation#5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

gvwilson
Copy link
Contributor

@gvwilsongvwilson commentedMay 22, 2025•
edited
Loading

-   Restore code removed in#4978.-   (Partially)closes#5186.
@gvwilsongvwilson requested a review fromemilyklMay 22, 2025 18:57
@gvwilsongvwilson self-assigned thisMay 22, 2025
@gvwilsongvwilson added P1needed for current cycle fixfixes something broken regressionthis used to work labelsMay 22, 2025
gvwilson added a commit that referenced this pull requestMay 22, 2025
-   Restore code removed in#4978.-   Finishes closing#5186.-   Depends on#5198.
Copy link
Contributor

@emilyklemilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Along with#5199 this seems to fix syntax highlighting in VSCode on my machine.

{repr(rel_classes)}
)
from typing import TYPE_CHECKING
if sys.version_info < (3, 7) or TYPE_CHECKING:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't needsys.version_info < (3, 7) anymore - our minimum is past that. Which means we may not needimport sys anymore either.

@gvwilson
Copy link
ContributorAuthor

closed in favor of#5199

@gvwilsongvwilson deleted the fix-5186-type-checking-codegen-changes branchMay 25, 2025 12:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson left review comments

@emilyklemilyklemilykl approved these changes

Assignees

@gvwilsongvwilson

Labels
fixfixes something brokenP1needed for current cycleregressionthis used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v6.1.0 breaks Pylance highlighting and produces errors
3 participants
@gvwilson@alexcjohnson@emilykl
[8]ページ先頭
©2009-2025 Movatter.jp