Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

implement pull request #3731 and add tests to fix #3065#5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
amiteitan wants to merge3 commits intoplotly:main
base:main
Choose a base branch
Loading
fromamiteitan:dev

Conversation

amiteitan
Copy link

@amiteitanamiteitan commentedMay 20, 2025
edited
Loading

Please uncomment this block and take a look at this checklist if your PR is making substantial changes todocumentation/impacts files in thedoc directory. Check all that apply to your PR, and leave the rest unchecked to discuss with your reviewer! Not all boxes must be checked for every PR :)

If your PR modifies code of theplotly package, we have a different checklist
below :-).

Documentation PR

  • I'veseen thedoc/README.md file
  • This change runs in the current version of Plotly on PyPI and targets thedoc-prod branch OR it targets themain branch
  • If this PR modifies the first example in a page or adds a new one, it is apx example if at all possible
  • Every new/modified example has a descriptive title and motivating sentence or paragraph
  • Every new/modified example is independently runnable
  • Every new/modified example is optimized for short line countand focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • The random seed is set if using randomly-generated data in new/modified examples
  • New/modified remote datasets are loaded fromhttps://plotly.github.io/datasets and added tohttps://github.com/plotly/datasets
  • Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • Imports areplotly.graph_objects as go /plotly.express as px /plotly.io as pio
  • Data frames are always calleddf
  • fig = <something> call is high up in each new/modified example (eitherpx.<something> ormake_subplots orgo.Figure)
  • Liberal use is made offig.add_* andfig.update_* rather thango.Figure(data=..., layout=...) in every new/modified example
  • Specific adders and updaters likefig.add_shape andfig.update_xaxes are used instead of bigfig.update_layout calls in every new/modified example
  • fig.show() is at the end of each new/modified example
  • plotly.plot() andplotly.iplot() are not used in any new/modified example
  • Hex codes for colors are not used in any new/modified example in favour ofthese nice ones

Code PR

  • I have read through thecontributing notes and understand the structure of the package. In particular, if my PR modifies code ofplotly.graph_objects, my modifications concern thecodegen files and not generated files.
  • [ X] I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@amiteitanamiteitan marked this pull request as ready for reviewMay 26, 2025 18:28
@gvwilsongvwilson self-assigned thisMay 28, 2025
@gvwilsongvwilson added P1needed for current cycle communitycommunity contribution fixfixes something broken labelsMay 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@gvwilsongvwilson

Labels
communitycommunity contributionfixfixes something brokenP1needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@amiteitan@gvwilson

[8]ページ先頭

©2009-2025 Movatter.jp