Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allowshared_yaxes to work with secondary axes#5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gmjw wants to merge4 commits intoplotly:main
base:main
Choose a base branch
Loading
fromgmjw:secondary-y-shared

Conversation

gmjw
Copy link

@gmjwgmjw commentedMay 12, 2025
edited
Loading

  • I have read through thecontributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or modified existing tests.
  • For a new feature, I have added documentation examples in an existing or new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

Theshared_yaxes parameter to make_subplots did not previously work onsecondary y-axes. It had no effect.

This PR fixes this, without affecting how the parameter is applied to normal plots (without secondary y-axes). I have added a simple test to show how the new code "matches" secondary y-axes. The sharing for secondary y-axes is applied right-to-left, in the same way that the sharing for primary y-axes is applied left-to-right (I believe this results in the clearest separation of tick marks when viewing the final plot).

I believe this is a bugfix/improvement. I'm not sure if it's a new feature worthy of any documentation.

I will add some images showing a before/after comparison in comments.

@gmjw
Copy link
Author

gmjw commentedMay 12, 2025
edited
Loading

This is the output of the test adjusted in the PR, withshared_yaxes=True, before and after the changes. You can see that after the changes the secondary y-axes are shared across rows, whereas previously only primary y-axes were shared.

fig_test_before
fig_test_after

@gmjw
Copy link
Author

This is my first PR to this repo, I've done my best but please let me know if there's anything I've forgotten or that could be done better.

In particular I'm not sure if/how I should add to the CHANGELOG file.

[{"secondary_y": True}, {"secondary_y": True}],
],
)
for shared_y_axes in [False, True]:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ideally I would have passed in these options usingmark.parametrize, but I don't think that is possible with unittest TestCase methods.

@gvwilsongvwilson self-assigned thisMay 20, 2025
@gvwilsongvwilson added featuresomething new P2considered for next cycle communitycommunity contribution labelsMay 20, 2025
@gvwilson
Copy link
Contributor

thanks@gmjw - I'll try to get this merged in for the 6.2 release.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@marthacryanmarthacryanAwaiting requested review from marthacryan

At least 1 approving review is required to merge this pull request.

Assignees

@gvwilsongvwilson

Labels
communitycommunity contributionfeaturesomething newP2considered for next cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@gmjw@gvwilson

[8]ページ先頭

©2009-2025 Movatter.jp