Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove failingff.create_choropleth test#5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
emilykl merged 1 commit intomainfromremove-create-choropleth-test
Apr 7, 2025

Conversation

emilykl
Copy link
Contributor

Had a chat with@marthacryan today about how to handle this failing test. Our conclusion is that since theff.create_choropleth() function has beendeprecated anyway since 4 years ago, the best solution is to simply remove this test.


The reason for the failure is thattheshapely 2.1.0 release bumps the GEOS dependency version which changes the implementation of some geometric functions and causesshapely to return slightly different values.

Normally we could just update the expected value in the test, but unfortunately shapely 2.1.0 is not compatible with Python 3.9 and below so we'd have to either have two different expected values depending on which Python version is running the test, OR pinshapely<=2.0.7 indefinitely in the test suite, neither of which are great solutions.

@emilyklemilykl merged commit533f504 intomainApr 7, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvwilsongvwilsongvwilson approved these changes

@marthacryanmarthacryanmarthacryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@emilykl@gvwilson@marthacryan

[8]ページ先頭

©2009-2025 Movatter.jp