Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix widget initialization issue in v6#5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jescalada
Copy link
Contributor

@jescaladajescalada commentedMar 20, 2025
edited
Loading

This PR fixes a problem with widgets not initializing properly when integrating with third-party libraries (such asipywidgets) in v6.0.0:#4998

It seems that some of the changes in#4956 modified variable names used to load the widget's layout and data.

Let me know if adding test cases for this is required (I believe it'd be hard to test since it relies on other libraries).
Edit: Added basic tests just in case!

Thank you!

Before fix

Image

After fix

Image

Please uncomment this block and take a look at this checklist if your PR is making substantial changes todocumentation/impacts files in thedoc directory. Check all that apply to your PR, and leave the rest unchecked to discuss with your reviewer! Not all boxes must be checked for every PR :)

If your PR modifies code of theplotly package, we have a different checklist
below :-).

Documentation PR

  • I'veseen thedoc/README.md file
  • This change runs in the current version of Plotly on PyPI and targets thedoc-prod branch OR it targets themain branch
  • If this PR modifies the first example in a page or adds a new one, it is apx example if at all possible
  • Every new/modified example has a descriptive title and motivating sentence or paragraph
  • Every new/modified example is independently runnable
  • Every new/modified example is optimized for short line countand focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • The random seed is set if using randomly-generated data in new/modified examples
  • New/modified remote datasets are loaded fromhttps://plotly.github.io/datasets and added tohttps://github.com/plotly/datasets
  • Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • Imports areplotly.graph_objects as go /plotly.express as px /plotly.io as pio
  • Data frames are always calleddf
  • fig = <something> call is high up in each new/modified example (eitherpx.<something> ormake_subplots orgo.Figure)
  • Liberal use is made offig.add_* andfig.update_* rather thango.Figure(data=..., layout=...) in every new/modified example
  • Specific adders and updaters likefig.add_shape andfig.update_xaxes are used instead of bigfig.update_layout calls in every new/modified example
  • fig.show() is at the end of each new/modified example
  • plotly.plot() andplotly.iplot() are not used in any new/modified example
  • Hex codes for colors are not used in any new/modified example in favour ofthese nice ones

Code PR

  • I have read through thecontributing notes and understand the structure of the package. In particular, if my PR modifies code ofplotly.graph_objects, my modifications concern thecodegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

adamreeve and MichalRIcar reacted with hooray emoji
jescaladaand others added3 commitsMarch 20, 2025 03:12
Fix widgets not initializing properly when integrating with third-party libraries (such as `ipywidgets`)
@gvwilsongvwilson added P1needed for current cycle communitycommunity contribution fixfixes something broken labelsMar 21, 2025
Copy link
Collaborator

@marthacryanmarthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for tracking this down! Tested with the reproducible example in the issue and it is now working for me with your changes. This looks like a great change and thank you for adding tests.

jescalada reacted with hooray emoji
@marthacryanmarthacryan merged commit799eb10 intoplotly:mainMar 25, 2025
4 checks passed
@MichalRIcar
Copy link

@jescalada , thank you for the prompt and great fix of the issue!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@marthacryanmarthacryanmarthacryan approved these changes

Assignees

@marthacryanmarthacryan

Labels
communitycommunity contributionfixfixes something brokenP1needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jescalada@MichalRIcar@marthacryan@gvwilson

[8]ページ先頭

©2009-2025 Movatter.jp