Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add back the mime renderer JL extension#5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
marthacryan merged 72 commits intomainfromnotebook-connected-default
Apr 16, 2025

Conversation

@marthacryan
Copy link
Collaborator

@marthacryanmarthacryan commentedMar 17, 2025•
edited
Loading

Fixes#5056 by adding back a mime renderer extension removed in#4822. We didn't realize at the time that this part of the code was serving an important purpose in keeping filesizes down for offline users.

danieleongari and spapiernik reacted with eyes emoji
@gvwilsongvwilson added P1needed for current cycle fixfixes something broken labelsMar 19, 2025
@marthacryanmarthacryan changed the titleDefault to notebook connected modeAdd back the mime renderer JL extensionMar 20, 2025
@marthacryanmarthacryanforce-pushed thenotebook-connected-default branch fromf942e97 to847b87cCompareApril 4, 2025 20:57
@marthacryan
Copy link
CollaboratorAuthor

Pinning the version of shapely here for tests to pass, but we should address that in another PR.

@marthacryan
Copy link
CollaboratorAuthor

@marthacryan Looks good! Can you updateCONTRIBUTING.md to explain how the Jupyterlab extension build process works (and also explain the new CI step)?

Done! Want to take a quick look to see if it makes sense?

marthacryanand others added2 commitsApril 15, 2025 13:11
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@marthacryanmarthacryanforce-pushed thenotebook-connected-default branch frombcfbd25 tof3a4278CompareApril 15, 2025 18:16
steps:
-uses:actions/checkout@v4
with:
persist-credentials:false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this needed?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

good point. Also got that from the other script

Copy link
Contributor

@emilyklemilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

@marthacryanmarthacryan merged commit4dded6c intomainApr 16, 2025
6 checks passed
@gvwilsongvwilson deleted the notebook-connected-default branchJune 4, 2025 12:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@emilyklemilyklemilykl approved these changes

+1 more reviewer

@gvwilsongvwilsongvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marthacryanmarthacryan

Labels

fixfixes something brokenP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plotly on jupyter creates HUGE notebooks file sizes

4 participants

@marthacryan@emilykl@gvwilson
[8]ページ先頭
©2009-2025 Movatter.jp