Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.7k
Move chart-studio and plotly-geo to separate repositories#4972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
release.md Outdated
| @@ -2,7 +2,10 @@ | |||
| # How to release plotly packages | |||
| There are 3 Python packages (`plotly`, `plotly-geo` and `chart-studio`) which need to be | |||
| published to PyPI and conda. In addition, there are various changelogs, github releases and forum announcements to do :) | |||
| published to PyPI and conda. The `plotly` package is located in this repository, while `plotly-geo` and `chart-studio` are located in their own separate repositories under those names. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I feel like you could just remove this entire paragraph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As is, this kind of implies that you'd want to also publish those when you publish plotly.py, which is pretty unlikely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point, I'll change the wording here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Love it! LGTM
9910078 intomasterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR removes the entire contents of the
chart-studioandplotly-geopackages from this repository.These packages, and their respective Git histories, have been moved to their own individual repositories:
Changes in this PR:
packages/python/chart-studioandpackages/python/plotly-geoconfig.yml:chart-studiofrom PyPI rather than installing from local directorychart-studiotesting workflow (Note: Was not being run anyway)contributing.mdandrelease.mdto remove references tochart-studioandplotly-geoRationale
Moves us to a '1 repo = 1 package on PyPI' structure, and makes it possible to drastically simplify the directory structure in the Plotly.py repository.