Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.7k
Treat range() as a simple array#4636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dniku wants to merge1 commit intoplotly:mainChoose a base branch fromdniku:patch-1
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fixesplotly#1798 (incorrectly closed during a recent cleanup).Allows range() to be passed where simple arrays are expected.Previously the following code```pythonimport plotly.graph_objects as gogo.Figure(go.Scatter(x=range(3), y=[3, 2, 1]))```failed with```---------------------------------------------------------------------------ValueError Traceback (most recent call last)<ipython-input-1-be3f9396b95f> in <cell line: 2>() 1 import plotly.graph_objects as go----> 2 go.Figure(go.Scatter(x=range(3), y=[3, 2, 1]))5 frames/usr/local/lib/python3.10/dist-packages/plotly/graph_objs/_scatter.py in __init__(self, arg, alignmentgroup, cliponaxis, connectgaps, customdata, customdatasrc, dx, dy, error_x, error_y, fill, fillcolor, fillpattern, groupnorm, hoverinfo, hoverinfosrc, hoverlabel, hoveron, hovertemplate, hovertemplatesrc, hovertext, hovertextsrc, ids, idssrc, legend, legendgroup, legendgrouptitle, legendrank, legendwidth, line, marker, meta, metasrc, mode, name, offsetgroup, opacity, orientation, selected, selectedpoints, showlegend, stackgaps, stackgroup, stream, text, textfont, textposition, textpositionsrc, textsrc, texttemplate, texttemplatesrc, uid, uirevision, unselected, visible, x, x0, xaxis, xcalendar, xhoverformat, xperiod, xperiod0, xperiodalignment, xsrc, y, y0, yaxis, ycalendar, yhoverformat, yperiod, yperiod0, yperiodalignment, ysrc, **kwargs) 3476 _v = x if x is not None else _v 3477 if _v is not None:-> 3478 self["x"] = _v 3479 _v = arg.pop("x0", None) 3480 _v = x0 if x0 is not None else _v/usr/local/lib/python3.10/dist-packages/plotly/basedatatypes.py in __setitem__(self, prop, value) 4871 # ### Handle simple property ### 4872 else:-> 4873 self._set_prop(prop, value) 4874 else: 4875 # Make sure properties dict is initialized/usr/local/lib/python3.10/dist-packages/plotly/basedatatypes.py in _set_prop(self, prop, val) 5215 return 5216 else:-> 5217 raise err 5218 5219 # val is None/usr/local/lib/python3.10/dist-packages/plotly/basedatatypes.py in _set_prop(self, prop, val) 5210 5211 try:-> 5212 val = validator.validate_coerce(val) 5213 except ValueError as err: 5214 if self._skip_invalid:/usr/local/lib/python3.10/dist-packages/_plotly_utils/basevalidators.py in validate_coerce(self, v) 401 v = to_scalar_or_list(v) 402 else:--> 403 self.raise_invalid_val(v) 404 return v 405 /usr/local/lib/python3.10/dist-packages/_plotly_utils/basevalidators.py in raise_invalid_val(self, v, inds) 285 name += "[" + str(i) + "]" 286 --> 287 raise ValueError( 288 """ 289 Invalid value of type {typ} received for the '{name}' property of {pname}ValueError: Invalid value of type 'builtins.range' received for the 'x' property of scatter Received value: range(0, 3) The 'x' property is an array that may be specified as a tuple, list, numpy array, or pandas Series```(tested via [Google Colab](https://colab.research.google.com/notebooks/empty.ipynb))After this change, it is possible to use `range()` in this context.A potential concern is Python 2 support — there, `range()` is a plain list. I have not tested this with Python 2.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1798 (incorrectly closed during a recent cleanup).
Allows range() to be passed where simple arrays are expected.
Previously the following code
failed with
(tested viaGoogle Colab)
After this change, it is possible to use
range()
in this context.A potential concern is Python 2 support — there,
range()
is a plain list. I have not tested this with Python 2.