Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Resolve incorrect shape clipping for domain-referenced shapes on n*10th subplot#7576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@emilykl
Copy link
Contributor

@emilyklemilykl commentedOct 8, 2025
edited
Loading

Closes#7463,closes#6362

Resolves issue where shapes referenced to thedomain of an axis id containing a zero (e.g.ref: 'x10 domain') were not clipped to the boundaries of the subplot, as they should have been.

Also adds an image mock for this issue to prevent regression.

Thanks to@Ike-lag and@DataScienceIsCool for reporting, and to@Ike-lag for identifying the faulty regex in the codebase!

Before:
7463_before

After:
7463_after

Steps for testing

  1. View the newzz_shapes_clipping_double_digit_subplots mock in the devtools dashboard (after runningnpm run build) and make sure the shapes in the lower-left subplot do not extend beyond the subplot boundaries
  2. If you want to see what the mock looks like onmaster, check outmaster, copy over thezz_shapes_clipping_double_digit_subplots.json file into the mocks dir, runnpm run build and then check the mock in the devtools dashboard.

Ike-lag reacted with hooray emoji
@emilyklemilyklforce-pushed thefix-7463-shape-clipping-double-digit-subplots branch fromd083982 to61c113bCompareOctober 8, 2025 19:41
@gvwilsongvwilson added P1needed for current cycle fixfixes something broken labelsOct 9, 2025
@emilyklemilykl merged commit49898bc intomasterOct 9, 2025
6 checks passed
@emilyklemilykl deleted the fix-7463-shape-clipping-double-digit-subplots branchOctober 9, 2025 17:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@camdecostercamdecostercamdecoster approved these changes

Assignees

@emilyklemilykl

Labels

fixfixes something brokenP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subplots not correctly clipping vrects every 10th subplot make_subplots + hrect rendering bug

4 participants

@emilykl@camdecoster@gvwilson

[8]ページ先頭

©2009-2025 Movatter.jp