Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Fix issue wherevisible property of one legend was affecting another#7574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
camdecoster approved these changesOct 9, 2025
361d8b5 intomaster 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#7559
Fixes issue where setting
layout.legend3.visibletofalsecaused bothlegendandlegend3to disappear.Also adds a Jasmine test to prevent regression.
It seems this bug was because
legend._idwas not being added to the processed legend object during thedefaultsstep ifvisiblewas false. This DID cause the legend not to be drawn (desirable), but it had the side effect of causing the plot step to "assume" the legend_idto belegendif not available, which caused the visibility setting to also be applied to the first legend (undesirable).Note that the onlyactual logic change is on line 242 of
src/components/legend/defaults.js; the other changes in that file are just auto-formatting changes.To test
layout.legend3.visiblefromtruetofalseand make sure that neither of the other two legends disappear. (legend3is not visible in any case becauseshowlegendis set tofalseat the trace level and there's only one trace in that legend)