Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix issue wherevisible property of one legend was affecting another#7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
emilykl merged 2 commits intomasterfromfix-7559-legend-visible
Oct 9, 2025

Conversation

@emilykl
Copy link
Contributor

@emilyklemilykl commentedOct 7, 2025
edited
Loading

Closes#7559

Fixes issue where settinglayout.legend3.visible tofalse caused bothlegend andlegend3 to disappear.

Also adds a Jasmine test to prevent regression.

It seems this bug was becauselegend._id was not being added to the processed legend object during thedefaults step ifvisible was false. This DID cause the legend not to be drawn (desirable), but it had the side effect of causing the plot step to "assume" the legend_id to belegend if not available, which caused the visibility setting to also be applied to the first legend (undesirable).

Note that the onlyactual logic change is on line 242 ofsrc/components/legend/defaults.js; the other changes in that file are just auto-formatting changes.

To test

@gvwilsongvwilson added P1needed for current cycle fixfixes something broken labelsOct 9, 2025
@emilyklemilykl merged commit361d8b5 intomasterOct 9, 2025
6 checks passed
@emilyklemilykl deleted the fix-7559-legend-visible branchOctober 9, 2025 18:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@camdecostercamdecostercamdecoster approved these changes

Assignees

@emilyklemilykl

Labels

fixfixes something brokenP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: legend3.visible = false affects visibility of other legend

4 participants

@emilykl@camdecoster@gvwilson

[8]ページ先頭

©2009-2025 Movatter.jp