Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Fix subtitle does not properly clear/remove from the chart#7571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…lear/remove from the chart
gvwilson commentedOct 7, 2025
Thanks for the fix@cminn10 - we'll see if we can find a reviewer for the next release. |
emilykl commentedOct 7, 2025
This bug is almost definitely my fault 🙂 Thank you@cminn10 for the very precise fix! @cminn10 This looks great. One nit -- this fix doesn't actually cause the subtitle to be removed when setting I'd like to add a Jasmine test to prevent a regression. Can you add this test to |
emilykl left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚀 Thanks@cminn10 !
emilykl commentedOct 8, 2025
Merging despite the image test failures, because those failures are unrelated andhave been fixed on main. |
3658023 intoplotly:masterUh oh!
There was an error while loading.Please reload this page.
Description
This PR fixes an issue where
layout.title.subtitledoes not properly clear/remove from the chart whensubtitleobject is not in place, orsubtitle.textset tonull, empty string, or whitespace-only values viaPlotly.relayout().Problem
When users attempted to clear a subtitle using any of these methods:
The subtitle would remain visible on the chart. The only workaround was to set it to transparent:
Root Cause
In
src/components/titles/index.js-Line 163: The conditionif(subtitleEnabled && subtitleElShouldExist)prevented D3's.exit().remove()from running when the subtitle needed to be cleared.Additional changes
subtitle.textNotes
This follows the same D3 enter/exit pattern already used for the main title element (lines 147-157 in the same file).