Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Implement #3722 Add date type to work with error bars#7570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
mshvarts commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Just saw few tests are failed, I haven't had time to look closely, since I haven't figured out how to run a single test instead of the whole suite, but I think it means few tests need to be changed and not due to an issue in the code. |
gvwilson commentedOct 7, 2025
mshvarts commentedOct 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry I work full time and don't have time now. I can try to look into it later if you let me know how to run individual tests on my machine? Every time I tried adding flags it just ran the whole test suite instead and takes forever to complete. |
emilykl commentedOct 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@mshvarts, thank you for the PR! You can run a single test filename by passing the filename, e.g. Within a file, you can also run just a single test by changing I'll try to find some time in the next few days to look at the test failures; we have a few tests which are sometimes flaky so the failures may or may not be due to these changes. |
oskarr commentedNov 5, 2025
I looked into the test failure briefly (as I need this functionality), and removing all changes except the one on line 29 makes it pass the hover_label test, but still renders error bars for me (I have not run all the other tests). For |
emilykl commentedNov 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@mshvarts Yes,@oskarr is correct, I did some testing of my own and the change on line 29 is the only change technically needed to enable these error bars. The other changes adding the So reverting all the changes except for the line 29 change is a good start. However the resulting outcomeonly works when the error bar size is specified in milliseconds, and it's possible we should support string values as well, so more work will be needed. |
alexcjohnson commentedNov 5, 2025
I'd suggest not blocking on that. As long as we want to support milliseconds as a format - which I think is the right call, and the only plausible interpretation of numbers here - then we can add string handling as a separate effort. Or more generally, other ways to provide this data; strings are good if we can settle on a clear and flexible standard for specifying time intervals, but another option would be to split it into two attributes: units (that default to milliseconds but could be any other time unit) and a number. |
emilykl commentedNov 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@alexcjohnson Fair enough! If you're fine with that limitation it's fine with me as well. @mshvarts Here's a mock showing the 4 different types of error bar specifications in combination with a date axis. JSON: {"data": [ {"name":"percent","x": ["2025-11-05","2025-11-06","2025-11-07"],"y": [10,12,11],"error_x": {"type":"percent","value":0.001 },"type":"scatter" }, {"name":"constant","x": ["2025-11-05","2025-11-06","2025-11-07"],"y": [7,9,8],"error_x": {"type":"constant","value":10800000 },"type":"scatter" }, {"name":"sqrt","x": ["2025-11-05","2025-11-06","2025-11-07"],"y": [4,6,5],"error_x": {"type":"sqrt" },"type":"scatter" }, {"name":"data","x": ["2025-11-05","2025-11-06","2025-11-07"],"y": [1,3,2],"error_x": {"type":"data","array": [7200000,14400000,21600000] },"type":"scatter" } ],"layout": {"title": {"text":"Error bars along date axis" } }}@alexcjohnson It seems to me that both the |
alexcjohnson commentedNov 6, 2025
Yeah that's right, |

Uh oh!
There was an error while loading.Please reload this page.
Issue:#3722
Not gonna say I didn't use GPT, which I did, but it worked for me as you can see:
I already did this in my repo and built it locally.
I just took the time to make this pull request out of care for others people having this problem and to contribute to this wonderful plugin.
PS: I tried running tests to make sure it doesn't break anything but they were already failing on my machine even before i made any changes. (So merge at your own risk)