Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
fix: Fix USA subunits, clean up land, coastlines topojson layers#7555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "noConsole": {"level":"off","options": {"allow": ["log"] } } | ||
| } | ||
| }, | ||
| "includes": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@camdecoster What is the effect of this config change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can override the global includes using this one. It included all the same stuff as the global one, so I removed it as redundant.
| asyncfunctioncreateSubunitsLayer({ name, resolution, source}){ | ||
| constfilter=['AUS','BRA','CAN','USA'].map((id)=>`adm0_a3 === "${id}"`).join(' || '); | ||
| // Only include USA for 'usa' scope since the UN and NE borders don't match exactly and slivers of Canada creep in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
slivers of Canada creep in
😄
emilykl left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚀
b04398c intomasterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Description
Omit Canadian provinces from USA subunits and snap polygons for land, coastlines topojson layers.
Closes#7528.
Changes
Screenshots
Testing
cd topojson && npm run buildTODO