Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: title text cannot be edited for multiple plots/components (regression since v3.0.0)#7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Lexachoc
Copy link
Contributor

Regression since v3.0.0 (#7212)

After introducingtitle.text, some plots and components edit function breaks. This PR the issue. Alsocloses#7512 .

Affected plots

  1. Ternary plot:aaxis.title.text,baxis.title.text, andcaxis.title.text
  2. Polar plot:radialaxis.title.text

Affected components

  1. Colorbar:title.text
  2. Rangeslider:xaxis.title.text

@Lexachoc
Copy link
ContributorAuthor

No ideas why thehttps://github.com/plotly/plotly.js/blob/bddbb149ba2ffe5baf310867ef6cf3c27af65d6a/test/jasmine/tests/transition_test.js fails.

.then(function(){
data[0].marker.color='black';
layout.xaxis.range=[-1,1];
returnPlotly.react(gd,data,layout);
})
.then(delay(50))
.then(function(){

I found that the increased delay time in#7343 is not long enough (I have no idea why it doesn't work in my case, as I haven't changed the transition logic I think).

After increasing the delay time from50 to100, it works when I runnpm run test-jasmine -- transition locally.

However, this is unreliable in the GitHub workflow! The delay may need to be increased.

@gvwilsongvwilson removed the request for review fromcamdecosterAugust 11, 2025 17:20
@gvwilsongvwilson added communitycommunity contribution P1needed for current cycle fixfixes something broken labelsAug 11, 2025
Copy link
Contributor

@emilyklemilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great@Lexachoc , thank you for the fix! 🚀

@emilyklemilykl merged commitda9e43e intoplotly:masterOct 7, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@emilyklemilyklemilykl approved these changes

Assignees

@emilyklemilykl

Labels

communitycommunity contributionfixfixes something brokenP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

title.text cannot be edited for multiple plots/components (regression since v3.0.0)

3 participants

@Lexachoc@emilykl@gvwilson
[8]ページ先頭
©2009-2025 Movatter.jp