Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Add method to check for WebKit WebView user agent string#7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
camdecoster merged 3 commits intomasterfromcam/7476/add-iswebkitwebview-check
Jul 21, 2025

Conversation

@camdecoster
Copy link
Contributor

@camdecostercamdecoster commentedJul 18, 2025
edited
Loading

Description

Adds utility method to check for WebKit WebView using user agent string.Closes#7476.

Changes

  • Adds utility method
  • Adds tests for user agent related methods

Testing

  • TBD

Notes

  • This change is necessary to enable logic when the library is being used in Plotly Studio
  • The regex test returned the proper result for everything that I threw at it, but let me know if you find a breaking string
  • An alternative (though narrower) approach is to test if the user is on a Mac and in aTauri webview

archmoj reacted with thumbs up emoji
@camdecostercamdecoster changed the titleCam/7476/add-iswebkitwebview-checkfeat: Add method to check for WebKit WebView user agent stringJul 18, 2025
@camdecostercamdecoster changed the titlefeat: Add method to check for WebKit WebView user agent stringfix: Add method to check for WebKit WebView user agent stringJul 18, 2025
@archmoj
Copy link
Contributor

Great fix.
💃

@archmojarchmoj added the bugsomething broken labelJul 21, 2025
@camdecostercamdecoster marked this pull request as ready for reviewJuly 21, 2025 19:04
@camdecostercamdecoster merged commitc1bd679 intomasterJul 21, 2025
6 checks passed
@camdecostercamdecoster deleted the cam/7476/add-iswebkitwebview-check branchJuly 21, 2025 19:10
@archmojarchmoj added the P1needed for current cycle labelJul 21, 2025
@archmojarchmoj mentioned this pull requestJul 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@archmojarchmojarchmoj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugsomething brokenP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isSafari regex check doesn't catch WebKit webview in Tauri browser

3 participants

@camdecoster@archmoj

[8]ページ先頭

©2009-2025 Movatter.jp