Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Use neweracorn version for building, to support newer JS syntax#7478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
acorn version for bundling, to support newer JS syntaxacorn version for building, to support newer JS syntax| "virtual-webgl":"^1.0.6" | ||
| }, | ||
| "overrides": { | ||
| "falafel": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alternatively we should propose a PR to falafel repository.
But the repository seems missing athttps://github.com/substack/node-falafel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
npm ls falafelplotly.js├─┬ browserify-transform-tools@1.7.0│ └── falafel@2.2.5 deduped├── falafel@2.2.5 overridden└─┬ regl-scatter2d@3.3.1 └─┬ glslify@7.1.1 └── falafel@2.2.5 deduped
This looks fine.
Also
npm run preversion
passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah I haven't been able to track down thefalafel repository anywhere online.
Maybe we should switch away from falafel entirely?
A quick Google search brings uphttps://github.com/loilo/yufka as a possible replacement but it's not widely used at all.
archmoj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💃
f7c4692 intomasterUh oh!
There was an error while loading.Please reload this page.
Closes#7477
Adds an override to
package.jsonso that we use a newer version ofacornfor building Plotly.js, which allows the use of some newer JS syntax which otherwise fails (see discussion in#7474).We still target 2016 JS for the build output.