Description

UsenewPlot if config has changed instead of_doPlot insidePlotly.react.

Closes#7551.
Supersedes#6395.

Changes

• Adds check to determine ifnewPlot should be used
• Updates tests per above change

Testing

• Be on master
• Launch Plotly DevTools
• Open mockline_scatter (other mocks could work, but I know this one does)
• Run the following snippet to update the mode bar buttons:

  lettoggle=truePlotly.react(gd,gd.data,gd.layout,{displaylogo:false,modeBarButtonsToAdd:[{name:'custombutton',title:toggle ?'Take PICTURE' :'Record MOVIE',icon:toggle ?Plotly.Icons.camera :Plotly.Icons.movie,click:()=>{}},],modeBarButtonsToRemove:["autoscale","pan2d","lasso2d","resetScale2d","select2d","toImage","zoom","zoomIn2d","zoomOut2d"]})

• Run this other snippet to update the label of the custom button:

  toggle=falsePlotly.react(gd,gd.data,gd.layout,{displaylogo:false,modeBarButtonsToAdd:[{name:'custombutton',title:toggle ?'Take PICTURE' :'Record MOVIE',icon:toggle ?Plotly.Icons.camera :Plotly.Icons.movie,click:()=>{}},],modeBarButtonsToRemove:["autoscale","pan2d","lasso2d","resetScale2d","select2d","toImage","zoom","zoomIn2d","zoomOut2d"]})

• Note that the button title and icon have not updated
• Switch to this branch
• Reload the mock
• Run the two snippets again
• Note that the button title and icon have changed

Notes

• This PR was originally created by@archmoj, but@camdecoster updated the OP with testing details
• Though this change fixes the issue with some config updates not being reflected in the new plot, it doesn't add the original config to the graph div likegd.data orgd.layout. For that reason, I don't think that this PR fixes the original issue inenable updating the config of a plot without changing other parameters #6394 so I'm not going to close that issue once this merges.