Jul 18, 2025 · Jul 17, 2025 · Jul 17, 2025 · Jul 18, 2025 · Jul 18, 2025 · Jul 18, 2025
diff --git a/src/lib/events.js b/src/lib/events.js
            internalEv.emit(event, data);
        };

        /*
         * Add a dummy event handler for 'wheel' event for Safari
         * to enable mouse wheel zoom.
         * https://github.com/d3/d3/issues/3035
         * https://github.com/plotly/plotly.js/issues/7452
         */
        if(typeof plotObj.addEventListener === 'function') {
            plotObj.addEventListener("wheel", () => {});
        }

        return plotObj;
    },

diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
    // Events.init is idempotent and bails early if gd has already been init'd
    Events.init(gd);

    // Add dummy event handler for 'wheel' event for Safari
    // to enable mouse wheel zoom
    // https://github.com/d3/d3/issues/3035
    // https://github.com/plotly/plotly.js/issues/7452
    d3.select(gd).on('wheel', function() {});

    if(Lib.isPlainObject(data)) {
        var obj = data;
        data = obj.data;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -59,6 +59,16 @@ var Events = {
		internalEv.emit(event, data);
		};

		/*
		* Add a dummy event handler for 'wheel' event for Safari
		* to enable mouse wheel zoom.
		* https://github.com/d3/d3/issues/3035
		* https://github.com/plotly/plotly.js/issues/7452
		*/
		if(typeof plotObj.addEventListener === 'function') {
		plotObj.addEventListener("wheel", () => {});
		}
Comment on lines +68 to +70 Copy link Contributor camdecosterJul 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Why is the`if` block necessary? Can`plotObj` be undefined? Copy link ContributorAuthor emilyklJul 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. @camdecoster There's severaltests which pass an empty object (`{}`) as`plotObj`, which was leading to anerror causing the test to fail. I'm not sure if`plotObj` is supposed to be a DOM object or if other types are allowed. Copy link ContributorAuthor emilyklJul 18, 2025• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Looks like in the actual code (tests aside),`Events.init()` is only called inone place, and the argument is the output of`getGraphDiv()`, which cannot be`null` or`undefined` but it could theoretically be some other type besides a DOM element. Copy link ContributorAuthor emilyklJul 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I wonder if we should modify the tests rather than adding this`if` statement. Copy link Contributor camdecosterJul 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Maybe just use the optional chaining operator? I think that would essentially do the same thing as the`if` block, but is more compact and you wouldn't have to update any tests. `plotObj?.addEventListener("wheel", () => {});` emilykl reacted with thumbs up emoji Copy link ContributorAuthor emilyklJul 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Nice, TIL. Copy link ContributorAuthor emilyklJul 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. @camdecoster I've reverted to the`if` statement due to the conditional chaining operator not being supported in our build pipeline (see#7477) -- are you OK with me merging as it is currently? Copy link Contributor camdecosterJul 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Yes, this code will work fine.

		return plotObj;
		},

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -64,12 +64,6 @@ function _doPlot(gd, data, layout, config) {
		// Events.init is idempotent and bails early if gd has already been init'd
		Events.init(gd);

		// Add dummy event handler for 'wheel' event for Safari
		// to enable mouse wheel zoom
		// https://github.com/d3/d3/issues/3035
		// https://github.com/plotly/plotly.js/issues/7452
		d3.select(gd).on('wheel', function() {});

		if(Lib.isPlainObject(data)) {
		var obj = data;
		data = obj.data;
Expand Down