Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Fix NaN positions for shapes when dragging them.#7470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
abe1cc69cd52622f2c4a013e3cc1c9966995fa469258c811aee3106f7cce307File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1426,6 +1426,43 @@ describe('Activate and edit editable shapes', function() { | ||
| .then(done, done.fail); | ||
| }); | ||
| it('should be possible to drag shapes referencing non-categorical axes', function(done) { | ||
my-tien marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| Plotly.newPlot(gd, { | ||
| data: [ | ||
| { | ||
| x: ["2015-02-01", "2015-02-02", "2015-02-03"], | ||
| y: [14, 17, 8], | ||
| mode: "line", | ||
| }, | ||
| ], | ||
| layout: { | ||
archmoj marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| xaxis: { title: { text: "Date" }, type: "date" }, | ||
| dragmode: "drawline", | ||
| shapes: [ | ||
| { | ||
| type: "rect", | ||
| xref: "x", | ||
| yref: "paper", | ||
| x0: "2015-02-02", | ||
| y0: 0, | ||
| x1: "2015-02-08", | ||
| y1: 1, | ||
| opacity: 0.2, | ||
| editable: true, | ||
| }, | ||
| ], | ||
| }, | ||
| }) | ||
| .then(function() { drag([[257.64, 370], [250, 300]]); }) // move lower left corner up and left | ||
| .then(function () { | ||
| var shapes = gd._fullLayout.shapes; | ||
| var obj = shapes[0]._input; | ||
| print(obj); | ||
| assertPos(obj.path, 'M250,300H1019V100H257.64Z'); | ||
archmoj marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| }) | ||
| .then(done, done.fail); | ||
| }); | ||
| }); | ||
| }); | ||