Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support forticklabelposition "inside"/"outside" for category axes withtickson set to "boundaries"#7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@my-tien
Copy link
Contributor

"top", "bottom", "left", "right" are still ignored iftickson is set to "boundaries".

DisclaimerI am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

…xes with `tickson` set to "boundaries"."top", "bottom", "left", "right" are ignored if `tickson` is set to "boundaries".
@gvwilsongvwilson added featuresomething new communitycommunity contribution P1needed for current cycle labelsMay 8, 2025
@my-tien
Copy link
ContributorAuthor

@emilykl@gvwilson In my other PR the baseline tests seem to be working again, maybe we can trigger this one's action as well to see if it works?

@emilykl
Copy link
Contributor

@my-tien I did re-trigger the tests and it's still failing -- I think it will need my PR#7418 to be merged but I'm just working through some final issues with that one, hopefully will be resolved by end of day.

@emilykl
Copy link
Contributor

emilykl commentedMay 21, 2025
edited
Loading

@my-tien I just merged#7418 which fixes theModuleNotFoundError: No module named 'plotly' error in themake-baselines CI step.

You should mergemainmaster into this branch, it will resolve some of the CI issues.

my-tien reacted with rocket emoji

@emilykl
Copy link
Contributor

emilykl commentedMay 22, 2025
edited
Loading

@my-tien Just making sure I understand the effect of this change — can you confirm whether the below is correct?

Previously, if you settickson='boundaries' and (ticklabelposition='inside' orticklabelposition='outside'),ticklabelposition had no effect. This PR makes it sotickson='boundaries' and (ticklabelposition='inside' orticklabelposition='outside') are both respected. Effectively this only makes a difference whenticklabelposition='inside', since'outside' is the default anyway.

@my-tien
Copy link
ContributorAuthor

my-tien commentedMay 22, 2025
edited
Loading

@my-tien Just making sure I understand the effect of this change — can you confirm whether the below is correct?

Previously, if you settickson='boundaries' and (ticklabelposition='inside' orticklabelposition='outside'),ticklabelposition had no effect. This PR makes it sotickson='boundaries' and (ticklabelposition='inside' orticklabelposition='outside') are both respected. Effectively this only makes a difference whenticklabelposition='inside', since'outside' is the default anyway.

Yes, exactly!

emilykl reacted with hooray emoji

@my-tien
Copy link
ContributorAuthor

my-tien commentedMay 23, 2025
edited
Loading

Am I right to assume that the failing tests require no action from my side?

FYI:
image
image

@emilykl
Copy link
Contributor

@my-tien TheMissing X server error is definitely unrelated to this PR.

The error in the warning-counting test also seems unrelated, although I'm not sure of the root cause.@alexcjohnson Have you ever run into failures of this test before?

my-tien reacted with thumbs up emoji

@emilykl
Copy link
Contributor

@my-tien Tests are passing now and I'm happy merging this as-is (unless@archmoj has any final comments?)

Thank you for the PR!

my-tien reacted with thumbs up emoji

@archmojarchmoj merged commite2fd2bb intoplotly:masterJun 9, 2025
4 of 5 checks passed
@my-tien
Copy link
ContributorAuthor

Thx a lot@emilykl and@archmoj 😸

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@archmojarchmojarchmoj left review comments

@gvwilsongvwilsongvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

communitycommunity contributionfeaturesomething newP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@my-tien@emilykl@gvwilson@archmoj@marthacryan

[8]ページ先頭

©2009-2025 Movatter.jp