Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Fix for #7416: Hidden ticklabels with ticklabelposition "inside" take up plot space#7417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
17 commits Select commitHold shift + click to select a range
150ccd3 Fixes #7416
my-tien684d05c Update some tests in axes_test.js, because hidden labels no longer ta…
my-tiena287e90 Add draftlog for 7417
my-tiene157374 Instead of removing text of hidden ticklabels, just set their display…
my-tien049b7fe Fix error: d3 selection.style called as getter
my-tien23a29f2 axes_test: Add precision param to new toBeCloseToArray call
my-tien8967732 Correct fix for "d3 selection.style called as getter"
my-tien2e8db5f Undo some changes done in 684d05c0 (break the CI)
my-tienb546d61 Undo change to left-over failing test since 684d05c0
my-tien846c0ab Try fixing failed baseline test container-colorbar-vertical-w-margin
my-tien65fed4a baseline image for zz-label-spacing
my-tiena0affdd Try fixing automargin behavior when setting display: 'none' for hidde…
my-tien930e057 Merge remote-tracking branch 'origin-plotly/master' into label-spacing
my-tienb3bc2ae Merge remote-tracking branch 'origin-plotly/master' into label-spacing
my-tien4c7f30a Update baseline images after adjustments for label spacing
my-tien7d71519 Merge remote-tracking branch 'origin-plotly/master' into label-spacing
my-tien6c2dbd6 use .node().style.display instead of .style('display')
emilyklFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
axes_test: Add precision param to new toBeCloseToArray call
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit23a29f21c2a2bc0f2a0f6b3ae8d87cf5b306cfdd
There are no files selected for viewing
2 changes: 1 addition & 1 deletiontest/jasmine/tests/axes_test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.