Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Move css-loader and others into devDependencies#7407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@hborchardt
Copy link
Contributor

@hborchardthborchardt commentedApr 23, 2025•
edited by archmoj
Loading

Fixes#7430.

Some recent PRs (#7142,#7140) introduced thecss-loader,style-loader andesbuild-style-plugin as dependencies. However it seems that they should be categorized as devDependencies instead, because they don't end up in the bundle, but are used to create the bundle.

This poses a problem for me, as it causesnpm install plotly.js to install significantly more dependencies than necessary.

In order to not install css-loader and its dependencies during anpm install plotly.js, turn them into devDependencies.

archmoj reacted with heart emoji
In order to not install css-loader and its dependencies during a`npm install plotly.js`, turn them into devDependencies.
@gvwilsongvwilson added featuresomething new communitycommunity contribution P1needed for current cycle infrastructurebuild process etc. labelsApr 30, 2025
Copy link
Collaborator

@alexcjohnsonalexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💃 This is great, absolutely these belong indevDependencies, thanks@hborchardt!

@mattrunyon
Copy link

I found this right after I opened a ticket about howesbuild-style-plugin can cause type errors as well with default tsconfig options.

#7430 which I proposed moving to dev dep as a fix since that should prevent the dep from installing a deprecated stub for@types/sass

archmoj reacted with thumbs up emoji

@archmojarchmoj changed the titleMove css-loader and others into devDependencieschore: Move css-loader and others into devDependenciesJun 4, 2025
@archmojarchmoj merged commite4eaf44 intoplotly:masterJun 4, 2025
5 checks passed
@aweebit
Copy link

aweebit commentedJul 8, 2025•
edited
Loading

@alexcjohnson@archmoj is this going to be published soon? And is it possible to backport this to v2?

In Yarn Classic, the fact thatstyle-loader is a regular dependency causes

warning "plotly.js > style-loader@4.0.0" has unmet peer dependency "webpack@^5.27.0".

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

@marthacryanmarthacryanAwaiting requested review from marthacryan

Assignees

@marthacryanmarthacryan

Labels

communitycommunity contributionfeaturesomething newinfrastructurebuild process etc.P1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

esbuild-style-plugin can cause type issues for sass

7 participants

@hborchardt@mattrunyon@aweebit@alexcjohnson@gvwilson@marthacryan@archmoj
[8]ページ先頭
©2009-2025 Movatter.jp