thanks@dimitrov570 - I'll see if we can get this into the 3.1 release.

I don't think the deleted countries counts as a breaking change.

I clicked the wrong button. Let me know when you make changes and I'll review again.

I clicked the wrong button. Let me know when you make changes and I'll review again.

Sorry, I was away. Let me know if anything else needs to be done.

Welcome back! There's a couple of failing tests due to the library change and country names not being available anymore. I should have it fixed today, then I'll merge it.

You would fix it or I should fix it? I'm not 100% sure what needs to be done, but I suppose just to remove the countries that are not present anymore from the tests, right?

You would fix it or I should fix it? I'm not 100% sure what needs to be done, but I suppose just to remove the countries that are not present anymore from the tests, right?

I took care of it. Once CI passes, I'll get it merged.

For future reference, there was an issue where ESBuild was treating the requireden.json file as JavaScript instead of JSON. The error I saw was this:Expected ";" but found ":". This was due to our use of an ESBuild pluginbrowserifyAdapter, where we passed a custom transform function:

I'm not sure why this happened because ESBuild can handle JSON files, but it was necessary to stringify the JSON to get ESBuild to recognize the file as JSON. An alternative that worked was to wrap the text inmodule.exports = { <JSON text> }, which is what ESBuild ultimately does during the build process.

On another note, the library that this PR replaces uses RegEx patterns to match country names which is pretty flexible (though a bit out of date). The new library looks for an exact match of lowercased strings. As such, some previous country names no longer find a match. For example, a location of Burma no longer returns the country code for Myanmar and a location of Moldova no longer matches because it needs to be "Moldova, Republic of". There are some open PRs to add alternative names (like just "Moldova"), but those haven't been getting approved very quickly. Once they do, we can update the library and make the country lookup a bit better.

@camdecoster For the country names that have changed, this will be a breaking change for charts showing those countries and usinglocationmode: 'country names', right? Should we hard-code previously-accepted names so that existing charts don't break?

Ultimately seems like we might want to eventually phase outlocationmode: 'country names' entirely because of problems like this.

Since this could be a breaking change, we're going to hold off until v4. I added a breaking change warning in 3.1.0.@gvwilson what's the best way to track this so we don't forget it?