Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Path pattern fills#7280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Path pattern fills#7280
Uh oh!
There was an error while loading.Please reload this page.
Conversation
test/image/mocks/pattern_bars.json Outdated
| "bgcolor":"black" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd like to keeppattern_bars.json as it was before.
Please duplicate the mock and name the new mockzz-pattern_bars-path.json.
This is wonderful feature.
Thanks@alexcjohnson for the PR. 🏆
We may introduce new features like this one inv3.1.0 notv3.0.0; even though one may argue that it's a low risk feature. BTW it requires extra testing on the python side, etc.
cc:@gvwilson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK - personally I think the mocks are getting a little excessive, and we'd be better off testing as many things as we can in one mock, which is why I just added this to one of the existing mocks. But I've made the change.
| ( | ||
| (nestedSchema.coerceNumber&&valIn!==+valOut)|| | ||
| (!isArrayOrTypedArray(valIn)&&valIn!==valOut)|| | ||
| (String(valIn)!==String(valOut)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because we're comparing the original data array to something we coerced off a deep copy, arrays that make it here will never be===
archmoj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💃 💃 💃
💃
💃 💃 💃 ool feature!
d745a1b intomasterUh oh!
There was an error while loading.Please reload this page.
Arbitrary fill patterns! For example geologists haveall sorts of standardized patterns they know and love, and this lets you create any pattern you want. It still has the constraint of two colors (foreground and background) and a square unit cell, but now any svg path string is accepted to define the foreground color area.
I chose to do this by adding a new attribute in the
patterncontainer,path. We could instead put the path into theshapeattribute - in fact we only accept one (shapetakes precedence) and for drawing I combine them into one anyway. And this is what we do forline.dashfor example, there's an enumerated set but you also have the option of providing an arbitrary string in the same place. On the other handlayout.shapeshas apathattribute fortype='path'shapes and other attributes for other shapes. Alsoline.dashis somewhat awkward to describe (astringattribute that nevertheless listsvalueslike an enum?) andshape='<path string>'is a bit funny to read. I don't feel strongly about this though - if others would prefer to add this into theshapeattribute that would also be fine.