Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Path pattern fills#7280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
archmoj merged 10 commits intomasterfromalex/path-pattern-fill
Jun 9, 2025
Merged

Path pattern fills#7280

archmoj merged 10 commits intomasterfromalex/path-pattern-fill
Jun 9, 2025

Conversation

@alexcjohnson
Copy link
Collaborator

Arbitrary fill patterns! For example geologists haveall sorts of standardized patterns they know and love, and this lets you create any pattern you want. It still has the constraint of two colors (foreground and background) and a square unit cell, but now any svg path string is accepted to define the foreground color area.

I chose to do this by adding a new attribute in thepattern container,path. We could instead put the path into theshape attribute - in fact we only accept one (shape takes precedence) and for drawing I combine them into one anyway. And this is what we do forline.dash for example, there's an enumerated set but you also have the option of providing an arbitrary string in the same place. On the other handlayout.shapes has apath attribute fortype='path' shapes and other attributes for other shapes. Alsoline.dash is somewhat awkward to describe (astring attribute that nevertheless listsvalues like an enum?) andshape='<path string>' is a bit funny to read. I don't feel strongly about this though - if others would prefer to add this into theshape attribute that would also be fine.

archmoj reacted with hooray emojiarchmoj and HazemBZ reacted with heart emoji
@alexcjohnsonalexcjohnson added the featuresomething new labelNov 22, 2024
"bgcolor":"black"
}
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to keeppattern_bars.json as it was before.
Please duplicate the mock and name the new mockzz-pattern_bars-path.json.

This is wonderful feature.
Thanks@alexcjohnson for the PR. 🏆

We may introduce new features like this one inv3.1.0 notv3.0.0; even though one may argue that it's a low risk feature. BTW it requires extra testing on the python side, etc.
cc:@gvwilson

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK - personally I think the mocks are getting a little excessive, and we'd be better off testing as many things as we can in one mock, which is why I just added this to one of the existing mocks. But I've made the change.

(
(nestedSchema.coerceNumber&&valIn!==+valOut)||
(!isArrayOrTypedArray(valIn)&&valIn!==valOut)||
(String(valIn)!==String(valOut))
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Because we're comparing the original data array to something we coerced off a deep copy, arrays that make it here will never be===

@gvwilsongvwilson added the P1needed for current cycle labelFeb 14, 2025
Copy link
Contributor

@archmojarchmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💃 💃 💃
💃
💃 💃 💃 ool feature!

robertcollar-kobold reacted with hooray emoji
@archmojarchmoj merged commitd745a1b intomasterJun 9, 2025
1 check passed
@archmojarchmoj deleted the alex/path-pattern-fill branchJune 9, 2025 21:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@emilyklemilyklAwaiting requested review from emilykl

1 more reviewer

@archmojarchmojarchmoj approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

featuresomething newP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcjohnson@archmoj@gvwilson@emilykl

[8]ページ先頭

©2009-2025 Movatter.jp