Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Drop support for passing a string to thetitle attribute, and drop support for deprecated attributestitlefont,titleposition,titleside, andtitleoffset#7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
emilykl merged 13 commits intomasterfromdrop-title-text-str
Oct 9, 2024

Conversation

@emilykl
Copy link
Contributor

@emilyklemilykl commentedOct 7, 2024•
edited
Loading

Closes:#7177

  • Drop support for passing a string to thetitle attribute (usetitle.text instead)
  • Drop support for deprecatedtitlefont attribute (usetitle.font instead)
  • Drop support for deprecatedtitleposition attribute (usetitle.position instead)
  • Drop support for deprecatedtitleside attribute (usetitle.side instead)
  • Drop support for deprecatedtitleoffset attribute (usetitle.offset instead)
  • Apply these changes apply to everywhere the above attributes appear(layout,colorbar,axis, etc.)

Also:

  • Remove jasmine tests corresponding to the removed attributes
  • Remove functions used for converting old attributes to new attributes

@emilykl
Copy link
ContributorAuthor

@archmoj Thanks very much for the review. I've removed the empty_deprecated keys. Do you have any other comments?

@gvwilsongvwilson added featuresomething new P1needed for current cycle labelsOct 8, 2024
Copy link
Contributor

@archmojarchmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💃

@archmoj
Copy link
Contributor

@emilykl Do you need my help resolving the conflicts with master?

@emilykl
Copy link
ContributorAuthor

@emilykl Do you need my help resolving the conflicts with master?

@archmoj Nope, all good!

@archmoj
Copy link
Contributor

💃

@emilyklemilykl merged commit7916edf intomasterOct 9, 2024
@emilyklemilykl deleted the drop-title-text-str branchOctober 9, 2024 20:24
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull requestMar 31, 2025
- remove deprecated titlefont, titleside, etc.- it is no longer valid to pass a plain string as "title"plotly/plotly.js#7212
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull requestMar 31, 2025
- remove deprecated titlefont, titleside, etc.- it is no longer valid to pass a plain string as "title"plotly/plotly.js#7212
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull requestApr 1, 2025
- remove deprecated titlefont, titleside, etc.- it is no longer valid to pass a plain string as "title"plotly/plotly.js#7212
ianroberts added a commit to ianroberts/DefinitelyTyped that referenced this pull requestMay 5, 2025
- remove deprecated titlefont, titleside, etc.- it is no longer valid to pass a plain string as "title"plotly/plotly.js#7212
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gvwilsongvwilsonAwaiting requested review from gvwilson

@marthacryanmarthacryanAwaiting requested review from marthacryan

1 more reviewer

@archmojarchmojarchmoj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emilyklemilykl

Labels

featuresomething newP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support of settingtitle to string (instead oftitle.text) as well astitlefont in v3?

4 participants

@emilykl@archmoj@gvwilson
[8]ページ先頭
©2009-2025 Movatter.jp