Commit623146f

committed

add @noCIdep jasmine tag to make ./tasks/noci_test.sh work again

1 parent28aed69 commit623146fCopy full SHA for 623146f

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ root=$(dirname $0)/..`
`6`	`6`	`# tests that aren't run on CI (yet)`
`7`	`7`
`8`	`8`	`# jasmine specs with @noCI tag`
`9`		`-npm run test-jasmine -- --tags=noCI --nowatch\|\| EXIT_STATE=$?`
	`9`	`+npm run test-jasmine -- --tags=noCI,noCIdep --nowatch\|\| EXIT_STATE=$?`
`10`	`10`
`11`	`11`	`# mapbox image tests take too much resources on CI`
`12`	`12`	`#`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -210,6 +210,13 @@ func.defaultConfig = {`
`210`	`210`	`// A few tests don't behave well on CI`
`211`	`211`	`// add@noCI to the spec description to skip a spec on CI`
`212`	`212`	`//`
	`213`	`+// Although not recommended, some tests "depend" on other`
	`214`	`+// tests to pass (e.g. the Plotly.react tests check that`
	`215`	`+// all available traces and transforms are tested). Tag these`
	`216`	`+// with@noCIdep, so that`
	`217`	`+// - $ npm run test-jasmine -- tags=noCI,noCIdep`
	`218`	`+// can pass.`
	`219`	`+//`
`213`	`220`	`// Label tests that require a WebGL-context by @gl so that`
`214`	`221`	`// they can be skipped using:`
`215`	`222`	`// - $ npm run test-jasmine -- --skip-tags=gl`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2560,7 +2560,7 @@ describe('Test plot api', function() {`
`2560`	`2560`	`});`
`2561`	`2561`	`});`
`2562`	`2562`
`2563`		`-describe('Plotly.react',function(){`
	`2563`	`+describe('@noCIdepPlotly.react',function(){`
`2564`	`2564`	`varmockedMethods=[`
`2565`	`2565`	`'doTraceStyle',`
`2566`	`2566`	`'doColorBars',`

Comments

(0)