Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork79
Add types from @types/plotly.js-dist-min, Typing update, Export PlotlyViaWindow and PlotlyViaCDN#288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| exporttypeData=any; | ||
| exporttypeLayout=any; | ||
| exporttypeConfig=any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removing this to use@type/plotly.js-dist-min
| export*from'./lib/plotly-via-cdn.module'; | ||
| export*from'./lib/plotly-via-window.module'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Undoing (accidental ?) Removal of this ? See issue linked in description
| {x:[1,2,3],y:[2,6,3],type:'scatter',mode:'lines+markers',marker:{color:'red'}}, | ||
| {x:[1,2,3],y:[2,5,3],type:'bar'}, | ||
| ], | ||
| layout:{width:320,height:240,title:'A Fancy Plot'} | ||
| layout:{width:320,height:240,title:{text:'A Fancy Plot'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
With new stronger types, this was compiling anymore, I had to update the sample
| { | ||
| "name":"angular-plotly.js", | ||
| "version":"20.0.0", | ||
| "version":"20.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggesting increment to release this, feel free to comment if it should be done in a separate PR/commit
Ghez239 commentedNov 5, 2025
any updates on release date? |
Uh oh!
There was an error while loading.Please reload this page.
Changes
@types/plotly.js-dist-minSince the README instructs us to use those types :
We might as well use those types for a better coherence with the latest updates and stronger typing
Also :
coverallsas it's unusedplotly.js-dist(in favor of the minified package)titleproperty change)Using types from the types library allows for smartter auto-completion :
(This used to be any[] with the previous definition from interface.ts)