Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork78
Fix: #198 - Error thrown in ngOnDestroy if plot not yet initialized#246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…izedThis can occur in unit tests if you do not await the component beingstable, so thisresolvesplotly#198. However, this could also happen ifngOnDestroy is called very quickly after ngOnInit.
Thank you,@paulirwin 😸 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can occur in unit tests if you do not await the component being stable, so thisresolves#198. However, this could also happen if ngOnDestroy is called very quickly after ngOnInit.
Note that the actual error happens inside createFigure, but given that the
PlotlyService.removecall needs theplotlyInstanceas well, and that other code checksplotlyInstancefor truthiness first, this seemed like a reasonable seam to introduce this check.The provided unit test failed before making this change, so this PR was done via TDD.
One bonus of this change is that it removes a use of the
!operator.