Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Actions menu description#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

kshitiz305
Copy link
Member

@kshitiz305kshitiz305 commentedMay 3, 2023•
edited
Loading

It then passes an action with this empty description to the template, where it becomes an empty title attribute.

Closes#24

It then passes an action with this empty description to the template, where it becomes an empty title attribute.plone#24
@mister-roboto
Copy link

@kshitiz305 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement:https://plone.org/foundation/contributors-agreement

@mister-roboto
Copy link

@kshitiz305 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass eitherstart all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@kshitiz305
Copy link
MemberAuthor

@jenkins-plone-org please run jobs

@ewohnlich
Copy link

It should maybe be action.get("description", "") so that the default remains an empty str instead of None, just in case that matters

@kshitiz305
Copy link
MemberAuthor

kshitiz305 commentedMay 3, 2023•
edited
Loading

Let me raise a new commit for it

It then passes an action with this empty description to the template, where it becomes an empty title attribute.plone#24
@mister-roboto
Copy link

@kshitiz305 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement:https://plone.org/foundation/contributors-agreement

It then passes an action with this empty description to the template, where it becomes an empty title attribute.plone#24
@mister-roboto
Copy link

@kshitiz305 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement:https://plone.org/foundation/contributors-agreement

@kshitiz305
Copy link
MemberAuthor

@jenkins-plone-org please run jobs

@kshitiz305
Copy link
MemberAuthor

@ewohnlich could you kindly do a code review and suggest any other changes to pass the Jenkin tests.

@ewohnlich
Copy link

I'm afraid I don't know much about the build/jenkins environment here. Maybe@gforcada ?

@petschki
Copy link
Member

@kshitiz305 hi and thank you for your contribution! Did you already sign the contributors agreement herehttps://plone.org/foundation/contributors-agreement ? If not please do so, otherwise we cannot merge this PR.

@mister-roboto
Copy link

@kshitiz305 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement:https://plone.org/foundation/contributors-agreement

@mister-roboto
Copy link

@kshitiz305 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass eitherstart all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada
gforcada previously requested changesMay 15, 2023
Copy link
Member

@gforcadagforcada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Re-running the jenkins jobs will probably clear the errors, we had a problem a few weeks ago withplone.app.caching, but they should be fine now

Co-authored-by: Gil Forcada Codinachs <gil.gnome@gmail.com>
@mister-roboto
Copy link

@kshitiz305 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement:https://plone.org/foundation/contributors-agreement

@kshitiz305
Copy link
MemberAuthor

@jenkins-plone-org please run jobs

@gforcada
Copy link
Member

@kshitiz305 it's already time to clear your contributor agreement, otherwise this PR will never get merged 😓 do you mind having a look at it? 👍🏾

@kshitiz305
Copy link
MemberAuthor

Will do it by today itself

@kshitiz305
Copy link
MemberAuthor

@kshitiz305 it's already time to clear your contributor agreement, otherwise this PR will never get merged 😓 do you mind having a look at it? 👍🏾

@gforcada I have signed the agreement Please do let me know if there is any thing pending from my end.

@kshitiz305
Copy link
MemberAuthor

@jenkins-plone-org please run jobs

@gforcada
Copy link
Member

@kshitiz305 thanks for signing the contributor agreement! let's see if it is processed quickly 🤞🏾 meanwhile double check your mail, as you will get an invitation to join the Plone organization ✨

Thanks for your efforts!

@kshitiz305
Copy link
MemberAuthor

@jenkins-plone-org please run jobs

@mauritsvanreesmauritsvanrees dismissedgforcada’sstale reviewMay 23, 2023 11:11

The requested change to the news snippet has been made.

Copy link
Member

@mauritsvanreesmauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

The Plone 6.1 Jenkins job fails with a version conflict, but that was already solved, so a rerun should fix it.

I see you are a member of the Plone organisation on GitHub now, welcome! Let me close and reopen this PR to see it that fixes the check for that.

@mister-roboto
Copy link

@kshitiz305 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass eitherstart all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member

The check now says:

"Plone Contributors Agreement verifier — All users have signed it".

Great!

The Jenkins 3.8 and 3.11 jobs were passing, so I will just rerun the 6.1 manually. Can be merged when that one is green.

@kshitiz305
Copy link
MemberAuthor

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

Only one random test failure in plone.app.multilingual, unrelated. I will merge.
Thanks for your contribution!

@mauritsvanreesmauritsvanrees merged commit0f5ca76 intoplone:masterMay 23, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mauritsvanreesmauritsvanreesmauritsvanrees approved these changes

@gforcadagforcadaAwaiting requested review from gforcada

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actions menu description - why leave blank?
7 participants
@kshitiz305@mister-roboto@ewohnlich@petschki@gforcada@mauritsvanrees@jensens
[8]ページ先頭
©2009-2025 Movatter.jp