Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a newpkgdev commit mangle to remove stable keywords#202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
anthonyryan1 wants to merge2 commits intopkgcore:main
base:main
Choose a base branch
Loading
fromanthonyryan1:main

Conversation

@anthonyryan1
Copy link

One of the most common maintenance tasks in the tree is a simple version bump. With this mangle,pkgdev commit can automatically remove the stable keyword from ebuilds copied from a prior version.

This should reduce contributor mistakes, and save developers time on both code review and manually editing keywords for their commits.

Kangie reacted with eyes emoji
One of the most common maintenance tasks in the tree is a simpleversion bump. With this mangle, `pkgdev commit` can automaticallyremove the stable keyword from ebuilds copied from a prior version.This should reduce contributor mistakes, and save developers timeon both code review and manually editing keywords for their commits.
@anthonyryan1
Copy link
Author

anthonyryan1 commentedNov 25, 2024
edited
Loading

Following some discussion in #gentoo-dev-help

--mangle false allows this to be disabled on a per-commit basis, piggybacking the existing option.@thesamesam expressed some opinion that this should have a separate toggle, but I felt like general helpful mangling all kind of fit well under that existing flag.

One problem I realized with this, is that it could destabilize a package unintentionally if the whole package is moved bygit mv

For examplegit mv old-category/package new-category/package orgit mv category/oldname category/newname would be caught up in this, and the new name would lose it's stability flags.

@anthonyryan1
Copy link
Author

I've added a second commit to cover the scenario where a package is renamed or moved to another category.

Because git treats all add & delete in the same commit as mv operations, we need to use a different approach to distinguish the two scenarios, we're now only removing stable keywords when the PV changes.

Happy to squash the commits, but I've left them separate until discussion is a bit further along.

Only redo the keywords if the PV changes over the git mv operation.
@anthonyryan1
Copy link
Author

There are multiple packages which get bumped straight to stable. The current idea is to add a flag tometadata.xml to indicate that a package is expected to be bumped straight to stable, once that gets implemented. This pull request needs to be amended to respect that flag.

For the moment, we are blocked awaiting that new feature.

@ferringb
Copy link
Contributor

@anthonyryan1 can you clarify "blocked awaiting that new feature"- specifically a link to discussions or upstream gentoo bug?

@anthonyryan1
Copy link
Author

@arthurzam do you have tracking link handy?

I'm afraid I've just got a brief IRC exchange, and I've put it out of mind until I heard otherwise.

Jun 16 13:15:18 <Ancient> arthurzam, I saw you released a new pkgdev version. Could I get your opinion/feedback on: https://github.com/pkgcore/pkgdev/pull/202 when you have some time? :)Jun 16 13:30:59 <Ancient> Ancient: we have multiple packages which are bumped straight to stable. Also, enabling always mangle is a good idea for most devs. We started an idea to add a new flag to metadata.xml which says "this is straight to stable package" hint. So for now your PR is blocked by this feature.Jun 16 13:33:33 <Ancient> Cheers, I'll add a comment to that PR to that effect. Thanks for the update. :)Jun 16 13:36:31 <Ancient> If there's anything i can do to help with the blocker, let me know. :)Jun 16 13:37:48 <Ancient> Just a fan of these automated mangles, I think they'll reduce time until outside PRs get merged by having less back and forth. :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anthonyryan1@ferringb

[8]ページ先頭

©2009-2025 Movatter.jp