Commit622bf1b

committed

fix: use throw and segregate the test cases

1 parentac30336 commit622bf1bCopy full SHA for 622bf1b

File tree

+17

-6

lines changed

+17

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,9 @@`
`18`	`18`	`constcheckRgbFormat=(colorRgb)=>colorRgb.every(c=>c>=0&&c<=255);`
`19`	`19`
`20`	`20`	`constrgbToHsl=(colorRgb)=>{`
`21`		`-if(checkRgbFormat(colorRgb)===false){`
`22`		`-return'Input is not a valid RGB color.'`
`23`		`-}`
	`21`	`+if(!checkRgbFormat(colorRgb)){`
	`22`	`+thrownewError('Input is not a valid RGB color.');`
	`23`	`+}`
`24`	`24`
`25`	`25`	`letcolorHsl=colorRgb`
`26`	`26`

Lines changed: 14 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import{rgbToHsl}from'../RgbHslConversion'`
`2`	`2`	`describe('RgbHslConversion',()=>{`
`3`		`-consttestCases=[`
	`3`	`+constvalidTestCases=[`
`4`	`4`	`[`
`5`	`5`	`[215,19,180],`
`6`	`6`	`[311,84,46]`
`@@ -28,16 +28,27 @@ describe('RgbHslConversion', () => {`
`28`	`28`	`[`
`29`	`29`	`[255,255,255],`
`30`	`30`	`[0,0,100]`
`31`		`-],`
	`31`	`+]`
	`32`	`+]`
	`33`	`+`
	`34`	`+consterrorTestCases=[`
`32`	`35`	`[[256,180,9],'Input is not a valid RGB color.'],`
`33`	`36`	`[[-90,46,8],'Input is not a valid RGB color.'],`
`34`	`37`	`[[1,39,900],'Input is not a valid RGB color.']`
`35`	`38`	`]`
`36`	`39`
`37`		`-test.each(testCases)(`
	`40`	`+`
	`41`	`+test.each(validTestCases)(`
`38`	`42`	`'Should return the color in HSL format.',`
`39`	`43`	`(colorRgb,expected)=>{`
`40`	`44`	`expect(rgbToHsl(colorRgb)).toEqual(expected)`
`41`	`45`	`}`
`42`	`46`	`)`
	`47`	`+`
	`48`	`+test.each(errorTestCases)(`
	`49`	`+'Should return the error message.',`
	`50`	`+(colorRgb,expected)=>{`
	`51`	`+expect(()=>rgbToHsl(colorRgb)).toThrowError(expected)`
	`52`	`+}`
	`53`	`+)`
`43`	`54`	`})`

Comments

(0)