NotificationsYou must be signed in to change notification settings
Fork4.9k
Star45.4k

Make AnimatedSprite event functions optional#6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bigtimebuddy merged 1 commit intopixijs:devfromdranitski:patch-1

Sep 27, 2020

Merged

Make AnimatedSprite event functions optional#6906

bigtimebuddy merged 1 commit intopixijs:devfromdranitski:patch-1

Sep 27, 2020

Conversation

Copy link

Contributor

dranitski commentedSep 25, 2020

this.animation.onComplete = undefined;
that line gives me an error in typescript
Type 'undefined' is not assignable to type '(...params: any[]) => any'.ts(2322)

EvenAnimatedSprite.destroy() function sets these tonull, so why can't I ?

public destroy(options: IDestroyOptions|boolean): void    {        this.stop();        super.destroy(options);        this.onComplete = null;        this.onFrameChange = null;        this.onLoop = null;    }

Description of change

Pre-Merge Checklist

Tests and/or benchmarks are included
Documentation is changed or added
Lint process passed (npm run lint)
Tests passed (npm run test)

Make AnimatedSprite event functions optional

d2c1997

```this.animation.onComplete = undefined;```that gives me an error in typescript```Type 'undefined' is not assignable to type '(...params: any[]) => any'.ts(2322)```Even `AnimatedSprite.destroy()` function sets these to `null`, so why can't I ?```public destroy(options: IDestroyOptions|boolean): void    {        this.stop();        super.destroy(options);        this.onComplete = null;        this.onFrameChange = null;        this.onLoop = null;    }```