Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.9k
Added in uint mappings#6768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I see you continue with hard stuff )
I'm honored that you understand our WebGL bindings. Its the part where JS is the best , you cant just write those things with same amount of code on strict-typed platforms. We also make sure that people can customize their WebGL usage, and even make direct calls, like for Texture Resources. Btw, can you also look if we have to adjust |
@ivanpopelyshev Will do, probably won't get to it till tomorrow. |
For more context on unsafe-eval, see this issue:#5463 Relevant source code: |
Just got the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Unsafe package looks like lots of CTRL+c, maybe we can generate it with eval().. oh .. right :)
Thank you@Mason-Chou! |
Description of change
Added in gl command and type mapping for uint. This is needed as the Typescript compiler will error out if you have a uint uniform in your shaders. See below for the error message.