- Notifications
You must be signed in to change notification settings - Fork37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Enhancement] Profile Click Zoom#322
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
works fine, would be nice if it were also zoomable, but already a big improvement 👍
Yeah was thinking the same. We could usehttps://www.npmjs.com/package/react-native-image-modal . Please let me know if any other ways we could achieve this. |
Also the resolution of the image seems to be abit low for profile pictures. Might have to update the backend for a better resolution image. But not a blocker for now.@dansup |
we could do it ourselves like@dansup did it for the zoomable pictures in the feed.
should be a separate endpoint, it makes not much sense to increase resolution/size for all profile images only for the rare case when you open it and zoom. |
Hey@Simon-Laux , cc -@dansup |
There seems to be some issue with the feedpost carousel. It filkers when we swipe on posts. Maybe because I a extracted the zoomImage component. Will make it ready for review once this issue is resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This removes panning from the zoom.
Otherwise looks good.
I was trying to make a generic component for the zoom but its causing issue with the feed as there is a swap to see difference images which flickers. So now I am not changing the feed zoom image now. Just adding zoom to the profile picture. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
code looks ok, didn't test
Changes
iOS Simulator
Screen.Recording.2025-03-24.at.1.57.56.AM.mp4
Blockers
NA
Related issues
Resolves :#204