Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Enhancement] Profile Click Zoom#322

Open
akshaykale17 wants to merge16 commits intopixelfed:main
base:main
Choose a base branch
Loading
fromakshaykale17:akshay/Profile_Image_Zoom

Conversation

akshaykale17
Copy link
Contributor

@akshaykale17akshaykale17 commentedMar 10, 2025
edited
Loading

Changes

  • Added feature to zoom the image if the user clicks the profile picture.
  • The modal is closed when the user touches the screen.

iOS Simulator

Screen.Recording.2025-03-24.at.1.57.56.AM.mp4

Blockers

NA

Related issues

Resolves :#204

Simon-Laux
Simon-Laux previously approved these changesMar 10, 2025
Copy link
Collaborator

@Simon-LauxSimon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

works fine, would be nice if it were also zoomable, but already a big improvement 👍

@akshaykale17
Copy link
ContributorAuthor

works fine, would be nice if it were also zoomable, but already a big improvement 👍

Yeah was thinking the same. We could usehttps://www.npmjs.com/package/react-native-image-modal . Please let me know if any other ways we could achieve this.

@akshaykale17
Copy link
ContributorAuthor

Also the resolution of the image seems to be abit low for profile pictures. Might have to update the backend for a better resolution image. But not a blocker for now.@dansup

@Simon-Laux
Copy link
Collaborator

Please let me know if any other ways we could achieve this.

we could do it ourselves like@dansup did it for the zoomable pictures in the feed.

Also the resolution of the image seems to be abit low for profile pictures. Might have to update the backend for a better resolution image.

should be a separate endpoint, it makes not much sense to increase resolution/size for all profile images only for the rare case when you open it and zoom.
so the open and zoom action should show lowers at first while it loads the highness in the background and replaces the shown image with the highness one as soon as it is loaded.

akshaykale17 reacted with thumbs up emoji

@akshaykale17
Copy link
ContributorAuthor

Hey@Simon-Laux ,
Have update the PR for adding the Zoom feature for profile picture. Update the PR description video as well. LMK if this LG.

cc -@dansup

Simon-Laux
Simon-Laux previously approved these changesMar 11, 2025
@akshaykale17akshaykale17 marked this pull request as draftMarch 23, 2025 11:29
@akshaykale17
Copy link
ContributorAuthor

There seems to be some issue with the feedpost carousel. It filkers when we swipe on posts. Maybe because I a extracted the zoomImage component. Will make it ready for review once this issue is resolved

@akshaykale17akshaykale17 marked this pull request as ready for reviewMarch 23, 2025 20:31
Copy link
Collaborator

@Simon-LauxSimon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This removes panning from the zoom.
Otherwise looks good.

@akshaykale17
Copy link
ContributorAuthor

This removes panning from the zoom. Otherwise looks good.

I was trying to make a generic component for the zoom but its causing issue with the feed as there is a swap to see difference images which flickers. So now I am not changing the feed zoom image now. Just adding zoom to the profile picture. Thank you!

Copy link
Collaborator

@Simon-LauxSimon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

code looks ok, didn't test

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Simon-LauxSimon-LauxSimon-Laux approved these changes

At least 6 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make (profile) pictures clickable for zoom
2 participants
@akshaykale17@Simon-Laux

[8]ページ先頭

©2009-2025 Movatter.jp